Re: [PATCH] Fix for Subversion issue #1789

2007-03-15 Thread Jonathan Gilbert
At 01:27 AM 3/15/2007 -0500, William A. Rowe, Jr. wrote: >Jonathan Gilbert wrote: [snip] >> Index: file_io/win32/readwrite.c >> === >> --- file_io/win32/readwrite.c(revision 515905) >> +++ file_io/win32/readwrite.c(work

Re: [PATCH] Fix for Subversion issue #1789

2007-03-15 Thread Erik Huelsmann
My gut says the extensive additional code to flip to buffered mode merits it's very own function (internal to apr would be fine, for now, but the fact that we need to trigger it hints that others might want to too, in some future 1.3.0 release.) We can't return 0 bytes written, too many apps will