Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Henry Jen
OK, I tried this on my OpenSolaris box, and believe I figured out what is going on. The dead-lock happens when the initial one worker thread get into idle first as no tasks are pushed yet, then two push comes in. Under this circumstance, there is one thread idle, thus no new thread will be created

Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Henry Jen
2010/9/27 Jeff Trawick : > On Mon, Sep 27, 2010 at 4:55 PM, Henry Jen wrote: >> 2010/9/27 Nick Kew : >>> > > (The next one is > https://issues.apache.org/bugzilla/show_bug.cgi?id=48722, which has no > patch.  Maybe I can debug it.) > I have a quick glance at it, and I would like to make a note th

Re: AIX-ers with a few minutes to test a makefile issue?

2010-09-27 Thread Eric Covener
On Mon, Sep 27, 2010 at 12:59 PM, Jeff Trawick wrote: > The submitter says make install bombs if APU_MODULES is empty, even > after other fixes that made it work on Solaris. testing with apr-1.4.x HEAD, an empty APU_MODULES causes that entire target to be skipped. If I invoke the specific target

Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Jeff Trawick
On Mon, Sep 27, 2010 at 4:55 PM, Henry Jen wrote: > 2010/9/27 Nick Kew : >> >> On 27 Sep 2010, at 13:12, Jeff Trawick wrote: >> >>> See https://issues.apache.org/bugzilla/show_bug.cgi?id=49709 and attached >>> patch. >>> >>> The patch makes conceptual sense to me, though I haven't studied the >>

Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Henry Jen
2010/9/27 Nick Kew : > > On 27 Sep 2010, at 13:12, Jeff Trawick wrote: > >> See https://issues.apache.org/bugzilla/show_bug.cgi?id=49709 and attached >> patch. >> >> The patch makes conceptual sense to me, though I haven't studied the >> details.  Perhaps someone has a head start on learning the

AIX-ers with a few minutes to test a makefile issue?

2010-09-27 Thread Jeff Trawick
https://issues.apache.org/bugzilla/show_bug.cgi?id=45276 The submitter says make install bombs if APU_MODULES is empty, even after other fixes that made it work on Solaris. The check in dso.m4 is already committed. Supposedly the other fix in Makefile.in is required on AIX. (Is this purely a she

Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Jeff Trawick
On Mon, Sep 27, 2010 at 9:36 AM, Nick Kew wrote: > > Henry, do you follow this list? If no reply, maybe you (Jeff) should copy > him your post. > I forwarded it to him off-line just in case. Thanks!

Re: [PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Nick Kew
On 27 Sep 2010, at 13:12, Jeff Trawick wrote: > See https://issues.apache.org/bugzilla/show_bug.cgi?id=49709 and attached > patch. > > The patch makes conceptual sense to me, though I haven't studied the details. > Perhaps someone has a head start on learning the apr thread pool > implementa

[PATCH] PR 49709 apr_thread_pool race condition caused by use of separate mutexes?

2010-09-27 Thread Jeff Trawick
See https://issues.apache.org/bugzilla/show_bug.cgi?id=49709 and attached patch. The patch makes conceptual sense to me, though I haven't studied the details. Perhaps someone has a head start on learning the apr thread pool implementation?