On 10 Oct 2013, at 12:37 AM, Jeff Trawick wrote:
> Work fine for me with the cmake-based build on Windows (MSVC).
>
> Thanks!
That's a relief. Thanks for the review, I appreciate it.
Regards,
Graham
--
On Wed, Oct 9, 2013 at 5:28 PM, Graham Leggett wrote:
> On 09 Oct 2013, at 10:34 PM, Jeff Trawick wrote:
>
> > The function is trying to escape any binary values that could
> conceivably cause problems when printed to the terminal, whether or not
> those values happen to have a C escape sequence
On 09 Oct 2013, at 10:34 PM, Jeff Trawick wrote:
> The function is trying to escape any binary values that could conceivably
> cause problems when printed to the terminal, whether or not those values
> happen to have a C escape sequence "shortcut". The escaping is done
> regardless IIUC. It
On Wed, Oct 9, 2013 at 4:25 PM, Graham Leggett wrote:
> On 03 Oct 2013, at 1:51 AM, Jeff Trawick wrote:
>
> > I dug into the glitches seen on Windows... \e is a non-portable escape
> (GNU extension), and shell escaping treats \n differently on Windows and
> OS/2, which the testcase didn't acco
On 03 Oct 2013, at 1:51 AM, Jeff Trawick wrote:
>
Fixed in r1530786.
Regards,
Graham
--
On 03 Oct 2013, at 1:51 AM, Jeff Trawick wrote:
> I dug into the glitches seen on Windows... \e is a non-portable escape (GNU
> extension), and shell escaping treats \n differently on Windows and OS/2,
> which the testcase didn't account for.
>
> I guess the code that used \e doesn't match a
(whoops, meant to respond to both places; I hate this list setup)
On Wed, Oct 9, 2013 at 3:33 PM, Jeff Trawick wrote:
> On Wed, Oct 9, 2013 at 3:17 PM, Graham Leggett wrote:
>
>> On 02 Oct 2013, at 3:40 PM, Jeff Trawick wrote:
>>
>> There is also the apr_escape API from v2.0 which has not been
On 02 Oct 2013, at 3:40 PM, Jeff Trawick wrote:
> There is also the apr_escape API from v2.0 which has not been backported yet.
>
> That doesn't work on Windows; relies (or just uses?) some non-portable escape
> sequence... I see the warnings roll by during compile and the testcase fails
> bu
