Re: [PATCH] Fix out of bounds write in apr_pbase64_encode() function

On 10/21/20 9:26 PM, Christopher Schultz wrote: > Denis, > > On 10/21/20 14:53, Denis Kovalchuk wrote: >> Hello. >> >> If I am not mistaken, there is an undefined behavior in apr_pbase64_encode() >> function: >> >> encoded = (char *) apr_palloc(p, apr_base64_encode_len(l)); >> l =

Re: [PATCH] Fix out of bounds write in apr_pbase64_encode() function

Denis, On 10/21/20 14:53, Denis Kovalchuk wrote: > Hello. > > If I am not mistaken, there is an undefined behavior in apr_pbase64_encode() > function: > > encoded = (char *) apr_palloc(p, apr_base64_encode_len(l)); > l = apr_base64_encode(encoded, string, l); > encoded[l] = '\0'; /*

[PATCH] Fix out of bounds write in apr_pbase64_encode() function

Hello. If I am not mistaken, there is an undefined behavior in apr_pbase64_encode() function: encoded = (char *) apr_palloc(p, apr_base64_encode_len(l)); l = apr_base64_encode(encoded, string, l); encoded[l] = '\0'; /* make binary sequence into string */ encoded[l] is out of bounds,