Re: [Patch] RFC 822 date parsing

2008-08-26 Thread Geoff Greer
at 22:23, Geoff Greer wrote: APR doesn't have any function for parsing an RFC 822 date. Seems it already has two. $ grep -ri 'RFC.*822' /usr/include/apr-1 /usr/include/apr-1/apr_date.h: * Sun, 06 Nov 1994 08:49:37 GMT ; RFC 822, updated by RFC 1123 /usr/include/apr-1/ap

[Patch] RFC 822 date parsing

2008-08-26 Thread Geoff Greer
Hey, it's the overzealous newb again. APR doesn't have any function for parsing an RFC 822 date. Since these dates show up in e-mail and http headers, I've attached a patch to trunk that adds apr_parse_rfc822_date. I've also added it to test_rfcstr, but the test is just for one date. I'm gu

apr_memcache_multgetp hangs forever after network hiccup

2008-08-26 Thread Geoff Greer
I had some problems at work with CGIs spinning. Attaching gdb gave me this: (gdb) bt #0 0x008e17a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2 #1 0x00166a86 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/ libpthread.so.0 #2 0x081e1cd7 in apr_reslist_acquire (reslist=0x8619860, res

Re: sendfile in darwin

2008-05-07 Thread Geoff Greer
OK, so there are two problems here: 1. Timeout sockets are broken in r654185. To test this cd to apr/test, make, then run ./sendfile server & ./sendfile client timeout Of course reverting the change (adding the rv=0 line again) causes the httpd tests to fail. I don't have the httpd tests set up

Re: Patch to fix sendfile on OS X

2008-04-25 Thread Geoff Greer
Ok, here's a patch for trunk that works with all test cases. I've put in most of the changes from wrowe's patch at http://people.apache.org/~wrowe/working.patch as well. >From what I can gather on the OS X man page (yay weasel-words! now you can't hold me accountable if I'm wrong), writev() will e

Re: Patch to fix sendfile on OS X

2008-04-24 Thread Geoff Greer
s; +(*len) = nbytes + header_bytes_written; if (rv == -1) { return errno; } On Apr 24, 2008, at 12:44 PM, Geoff Greer wrote: Instead of my last suggestion to disable sendfile on 10.5, I've fixed apr_socket_sendfile. The patch is attached. You can apply it by checking out tr

Patch to fix sendfile on OS X

2008-04-24 Thread Geoff Greer
Instead of my last suggestion to disable sendfile on 10.5, I've fixed apr_socket_sendfile. The patch is attached. You can apply it by checking out trunk: cd apr/network_io/unix patch -p0 < sendrecv.c.patch Now the sendfile test case passes on OS X. This is my first real patch, so suggestions are

Sendfile enabled on OS X in APR versions > 1.2

2008-04-21 Thread Geoff Greer
the following lines: *darwin*) # darwin semantics in 9.0.0 appear to be fubar sendfile="0" ;; which are missing in trunk's configure.in. Even though it's only a one line change, a patch is attached. Paul Querna says this should also be backported to the 1.3 b