Re: [PATCH] filepath.c with Borland C++ Builder

d? > > > > > > No need to send an updated patch; I'll just go ahead and commit > it now if the change is okay with you. Yup that would be great, thanks :) Saxon

Re: [PATCH] filepath.c with Borland C++ Builder

- Original Message - From: "Brian Pane" <[EMAIL PROTECTED]> To: "APR dev" Sent: Wednesday, June 25, 2003 2:42 PM Subject: Re: [PATCH] filepath.c with Borland C++ Builder > Saxon Druce wrote: > > >--- apr/file_io/win32/filepath.c.oldTue May 13

[PATCH] Borland C++ Builder signals

al.h, includes signal.h to ensure the system definitions are available in apr_private.h, and only defines SIGUSR1 and SIGUSR2 if they're not previously defined (eg in signal.h). Is there something wrong with the patch, or is the person responsible for reviewing it just busy? Should I keep

[PATCH] filepath.c with Borland C++ Builder

sible to compile the file. Is there something wrong with the patch, or is the person responsible for reviewing it just busy? Should I keep posting it every so often? Thanks, Saxon Druce ([EMAIL PROTECTED]) --- --- apr/file_io/

[PATCH] Borland C++ Builder signals

Hi, This is a repost of the patch below which I submitted about three weeks ago. Thanks, Saxon --- Hi, The patch below fixes about a hundred warnings like this: [C++ Warning] signal.h(65): W8017 Redefinition of 'SIGUSR1&#x

[PATCH] filepath.c with Borland C++ Builder

Hi, This is a repost of the patch below which I submitted about three weeks ago. Thanks, Saxon --- Hi, Borland C++ Builder 6.0 (ie bcc32 5.6) doesn't seem to like this kind of initialiser in win32's filepath.c: char s

Re: Using APR with Borland C++

27; is not identical [C++ Warning] apr_private.h(134): W8017 Redefinition of 'SIGUSR2' is not identical This was sent to the APR dev mailing list as a patch on the 14th of May 2003. **** * Let me know what problems you ge

[PATCH] Borland C++ Builder signals

of 'SIGUSR1' is not identical [C++ Warning] apr_private.h(134): W8017 Redefinition of 'SIGUSR2' is not identical When compiling APR using Borland C++ Builder, as discussed in the other email called 'Borland C++ Builder signals'. Thanks, Saxon ---

Borland C++ Builder signals

hem re-defined to the same value. If someone could let me know which way this should be solved, I'll supply a proper 'diff -u' patch. Thanks, Saxon

[PATCH] filepath.c with Borland C++ Builder

Hi, Borland C++ Builder 6.0 (ie bcc32 5.6) doesn't seem to like this kind of initialiser in win32's filepath.c: char seperator[2] = { (flags & APR_FILEPATH_NATIVE) ? '\\' : '/', 0}; The patc

apr_poll() with !HAVE_POLL and >FD_SETSIZE sockets

, which would allow polling with >FD_SETSIZE sockets, would be to try to dynamically allocate an fd_set which is big enough. I don't think that could be done portably though? Saxon

Re: APR_POLLHUP?

7;, only POLLIN, POLLOUT and POLLPRI should be in the requested events anyway. I've also noticed that if the APR_POLLPRI event is requested, the socket is added to the except set in select() (as it should be), but if it is signalled, the returned event is APR_POLLERR. I don't use AP

APR_POLLHUP?

(Win32 or !HAVE_POLL) it can't be? cya, Saxon

Re: apr_sockaddr_info_get: Posible bug

c library I can't link > my application. > > Also any sugestion for this? You definitely need to define APR_DECLARE_STATIC to link with a static lib. You said before that this gave you other errors, so what were they? bye, Saxon

Re: Problems compiling APR sources on Windows - PLEASE HELP

mpile my simple aplication? In VC6 at least, the place to put APR_DECLARE_STATIC is under Project -> Settings -> C/C++ tab -> Category: Preprocessor -> Preprocessor definitions. I'm not sure of the equivalent for VC7, but that fixed the same problem for me. bye, Saxon

Re: [PATCH] WIN32 implementation of apr_poll_revents_get()

asking for confirmation that this was wrong, and offering to write a patch to fix it if so. I was going to wait until my first patch to poll.c was committed before chasing this up any further, though. bye, Saxon Druce ([EMAIL PROTECTED])

Re: [PATCH] WIN32 implementation of apr_poll_revents_get()

If it hasn't been committed because there's something wrong with it, I'd be happy to write it a different way. Eg it can be done without a call to getsockopt() by adding a 'connected' flag to the apr_socket_t structure, just like the unix version does if HAVE_POLL is false. cya, Saxon Druce ([EMAIL PROTECTED])

Re: cvs commit: apr/file_io/win32 open.c pipe.c

And the previous line should be: (*file)->flags = flags; (I submitted a patch for that one about 2 months ago). cya, Saxon Druce ([EMAIL PROTECTED])

[PATCH] Re: Resend ([Q] apr_poll_revents_get() before apr_accept() on Windows)

ytes received (dummy is the number of bytes) + * from a stream socket indicates graceful shutdown. + */ +revents ^= APR_POLLIN; +revents |= APR_POLLHUP; } } } ====

win32 poll.c

osted a while ago, but which hasn't been checked into CVS (I don't think)? While I'm changing poll.c, should I do anything about apr_poll_setup() not doing anything constructive with the num parameter (which I posted an email about a while ago)? bye, Saxon Druce ([EMAIL PROTECTED])

Re: Borland C Builder 5

t; >+#pragma warn -sus /* suspicious pointer conversion */ > >+#pragma warn -pch /* cannot create pre-compiled header */ > >+#pragma warn -pia /* possibly incorrect assignment */ > >+#pragma warn -rch /* unreachable code */ > > > I agree with -rch and -pch, perhaps -sus (although see my comment > above), but not -pin, because it can be easily fixed. Ok, here's a new patch with those two, to make it easier: --- include/apr.hw.old Wed Mar 27 17:06:25 2002 +++ include/apr.hw Thu Mar 28 09:31:13 2002 @@ -79,6 +79,7 @@ extern "C" { #endif +#ifndef __BORLANDC__ /* disable or reduce the frequency of... * C4057: indirection to slightly different base types * C4075: slight indirection changes (unsigned short* vs short[]) @@ -89,6 +90,11 @@ * C4514: unreferenced inline function removed */ #pragma warning(disable: 4100 4127 4201 4514; once: 4057 4075 4244) +#else +/* disable warnings for Borland C */ +#pragma warn -pch /* cannot create pre-compiled header */ +#pragma warn -rch /* unreachable code */ +#endif #define APR_INLINE __inline #define APR_HAS_INLINE 1 cya, Saxon Druce ([EMAIL PROTECTED])

Borland C Builder 5

LANDC__ /* disable or reduce the frequency of... * C4057: indirection to slightly different base types * C4075: slight indirection changes (unsigned short* vs short[]) @@ -89,6 +90,13 @@ * C4514: unreferenced inline function removed */ #pragma warning(disable: 4100 4127 4201 4514; once: 4057 4075 4244) +#else +/* disable warnings for Borland C */ +#pragma warn -sus /* suspicious pointer conversion */ +#pragma warn -pch /* cannot create pre-compiled header */ +#pragma warn -pia /* possibly incorrect assignment */ +#pragma warn -rch /* unreachable code */ +#endif #define APR_INLINE __inline #define APR_HAS_INLINE 1 cya! Saxon Druce ([EMAIL PROTECTED])

Re: [Q] apr_poll_revents_get() before apr_accept() on Windows

Ok sure, here it is (attached). bye, Saxon - Original Message - From: "Sander Striker" <[EMAIL PROTECTED]> To: "Saxon" <[EMAIL PROTECTED]>; Sent: Monday, March 25, 2002 4:27 PM Subject: RE: [Q] apr_poll_revents_get() before apr_accept() on Windows

Re: [Q] apr_poll_revents_get() before apr_accept() on Windows

tream-type socket, that indicates a graceful shutdown (APR_POLLHUP instead of APR_POLLIN). I can create a proper diff-style patch for this if people agree it's sensible? cya, Saxon - Original Message - From: "INOUE Seiichiro" <[EMAIL PROTECTED]> To: Sent: Monda

apr_poll_setup

ockets, but this time the limit is 1024. Or maybe I've missed the point entirely :) This is all based on a cvs snapshot I downloaded yesterday, called apr_20020322112848.tar.gz. bye, Saxon