+1 from me.
david
> The following patch does the trick. I've actually attached two patches,
> the first is the APR change and the second is the update to the worker
> MPM to use the new function signature. What's changed in APR:
> apr_thread_exit no longer takes a pointer to an apr_status_t, whi
I'm seeing a lot of errors when trying to decide which db to use in apr-
util. The exact errors will have to wait until I get home, but the final
bit of the error says to use --with-dbm=, but that doesn't work either!!
Any ideas?
david
Thanks Jeff.
> Fix syntax error. I suspect this is what David intended
> in the previous commit.
It is probably closer to what I actually intended. :)
We should maybe try and check if the file exists before we remove it though
to stop silly errors being presented to the user.
david
> Justin Erenkrantz wrote:
>
>>Yeah, David had some local changes that he didn't commit that were in
>>his sms_pools_patch.
>>
>>Since we weren't building, I just committed the relevant chunks into
>>APR. Try again. Works here without his patch. This may make his
>>posted patch go freaky. Oh,
> now... you guys may have palloc() returning NULL because you've put a
> layer of indirection into pools so that you can have pools on top of
> exotic storages. if that's the case, then i really hope that one of
> those exotic pools is never passed to an httpd routine expecting a
> plain old memo
Thanks Justin.
The problem was that the patch was developed across 3 different OS's and
about 6 revisions, so whilst trying to keep about 4 tree's in sync I guess
I missed some stuff. Apologies for that :(
I'm sitting in a Cyber Cafe waiting for a train, but am trying to catch up
having had a
Well I can (as normal) see both sides of the argument :)
I've done the change for APR_ENOTIMPL as I agree that's probably better than
having more error codes, but I'd rather we try to
give the user as much information as possible. If people feel strongly enough
we can move to APR_EINVAL, but I
Folks,
Sitting here I'm wondering if we should add a pool to the time
functions? Basically the reason I'm asking is that I may have a
requirement to allocate and pass a string from some functions, so would
need access to a pool to allocate it in an ieal world. Any objections
if I do this? I kno