Re: [PATCH] Fix loop termination in apr_file_write

2005-08-22 Thread Joe Orton
On Sun, Aug 21, 2005 at 04:36:51PM +0200, Erik Huelsmann wrote: > On 8/20/05, Joe Orton <[EMAIL PROTECTED]> wrote: > > > > I promissed Karl Fogel a reproduction recipe, but didn't succeed in > > > creating one. OTOH, I think it's clear the line needs changing... > > > > I've committed this with a

Re: [PATCH] Fix loop termination in apr_file_write

2005-08-21 Thread Erik Huelsmann
On 8/20/05, Joe Orton <[EMAIL PROTECTED]> wrote: > > I promissed Karl Fogel a reproduction recipe, but didn't succeed in > > creating one. OTOH, I think it's clear the line needs changing... > > I've committed this with a test case (trying to write to a file which > was opened read-only), thanks

Re: [PATCH] Fix loop termination in apr_file_write

2005-08-20 Thread Joe Orton
On Fri, Aug 19, 2005 at 10:41:22PM +0200, Erik Huelsmann wrote: > Sometimes Subversion ends in an unterminated loop when checking out to > a full device. Looking at the Windows and OS/2 code, the unix code > seems to be missing a line which changes the loop termination variable > rv. > > I promiss

[PATCH] Fix loop termination in apr_file_write

2005-08-19 Thread Erik Huelsmann
Sometimes Subversion ends in an unterminated loop when checking out to a full device. Looking at the Windows and OS/2 code, the unix code seems to be missing a line which changes the loop termination variable rv. I promissed Karl Fogel a reproduction recipe, but didn't succeed in creating one. OTO