On Tue, Nov 16, 2004 at 01:30:00PM +, Julian Foad wrote:
Branko ibej wrote:
If the #if was an exception WRT the BEOS symbol, then
your change is fine; but you should say so (perhaps you did in another
post and I missed it; sorry).
I did say so when I first posted the patch a few days
Joe Orton wrote:
The fact that -Wundef exposed bugs like apr_signal_block() being a noop
seems like sufficient justification to make the source -Wundef clean to
avoid future screwups, I agree with this. But any chance you could fix
them all rather than picking them off one at at time?
Julian Foad wrote:
This patch only fixes one instance, but one which is in a header file
and so is encountered frequently. There are other BEOS-related
symbols being tested badly in C files which I am not fixing here. I
found these with gcc -Wundef.
I'm not sure this is a good change. As has
Brane, you have caught me in zero-tolerance week. Please bear with me while I
rant again. :-)
Branko ibej wrote:
Julian Foad wrote:
This patch only fixes one instance, but one which is in a header file
and so is encountered frequently. There are other BEOS-related
symbols being tested badly
I'm not saying who is correct here, but in the _VERY_ early days of
APR (back before we had our own mailing list), we had a discussion
about this very topic. The goal back then was to determine if #if
could be used instead of #ifdef or #if defined(). We decided back
then to always use #if
Ryan Bloom [EMAIL PROTECTED] writes:
I'm not saying who is correct here, but in the _VERY_ early days of
APR (back before we had our own mailing list), we had a discussion
about this very topic. The goal back then was to determine if #if
could be used instead of #ifdef or #if defined(). We
Julian Foad wrote:
Brane, you have caught me in zero-tolerance week. Please bear with me
while I rant again. :-)
:-)
I don't disagree with what you said, I was merely pointing out a (the?)
potential catch. If the #if was an exception WRT the BEOS symbol, then
your change is fine; but you
Branko ibej wrote:
If the #if was an exception WRT the BEOS symbol, then
your change is fine; but you should say so (perhaps you did in another
post and I missed it; sorry).
I did say so when I first posted the patch a few days ago, but I should say so
in the log message. The patch is
This patch only fixes one instance, but one which is in a header file and so is
encountered frequently. There are other BEOS-related symbols being tested
badly in C files which I am not fixing here. I found these with gcc -Wundef.
- Julian
Test whether BEOS is defined, not whether it is
