On Thu, 2004-07-08 at 09:00 +0100, Joe Orton wrote:
> On Wed, Jul 07, 2004 at 02:59:47PM -0400, Craig Rodrigues wrote:
> > On Wed, Jul 07, 2004 at 05:57:42PM +0100, Joe Orton wrote:
> > > > We should probably disable kqueue support in FreeBSD versions less
> > > > than 4.8 or so.
> > >
> > > Gotta
On Wed, Jul 07, 2004 at 02:59:47PM -0400, Craig Rodrigues wrote:
> On Wed, Jul 07, 2004 at 05:57:42PM +0100, Joe Orton wrote:
> > > We should probably disable kqueue support in FreeBSD versions less
> > > than 4.8 or so.
> >
> > Gottapatch?
Ugh, this didn't work for my automated builds since they
On Wed, Jul 07, 2004 at 05:57:42PM +0100, Joe Orton wrote:
> > We should probably disable kqueue support in FreeBSD versions less
> > than 4.8 or so.
>
> Gottapatch?
Index: configure.in
===
RCS file: /home/cvspublic/apr/configure.i
On Wed, 2004-07-07 at 12:31 -0400, Craig Rodrigues wrote:
> We should probably disable kqueue support in FreeBSD versions less than 4.8
> or so.
>
I agree. I know there were some bug fixes to KQueue in early 4.X, and I
don't have that old of FreeBSD around to support KQueue on them.
-Paul Quern
On Wed, Jul 07, 2004 at 12:31:12PM -0400, Craig Rodrigues wrote:
> On Wed, Jul 07, 2004 at 08:46:27AM +0100, Joe Orton wrote:
> > Paul, there's a problem on FreeBSD 4.2 - there is no EV_SET() macro.
...
> On your system, what is the output of:
> sysctl kern.osreldate
kern.osreldate: 42
> We s
On Wed, Jul 07, 2004 at 08:46:27AM +0100, Joe Orton wrote:
> Paul, there's a problem on FreeBSD 4.2 - there is no EV_SET() macro.
>
> #ifndef EV_SET
> #undef HAVE_KQUEUE
> #endif
>
> somewhere near the the top of poll.c? Or is there are more subtle
> fix?
On your system, what is the output o
Paul, there's a problem on FreeBSD 4.2 - there is no EV_SET() macro.
#ifndef EV_SET
#undef HAVE_KQUEUE
#endif
somewhere near the the top of poll.c? Or is there are more subtle
fix?
joe
--On Tuesday, June 15, 2004 8:41 AM -0700 Paul Querna <[EMAIL PROTECTED]>
wrote:
On Mon, 2004-06-07 at 21:21 +0100, Joe Orton wrote:
Ah, also pollset_create will need to register a cleanup now there is
something to clean up now I notice...
Updated Patch w/ pool cleanups attached.
The cleanup synt
> On Mon, 2004-06-07 at 21:21 +0100, Joe Orton wrote:
> Ah, also pollset_create will need to register a cleanup now there is
> something to clean up now I notice...
Updated Patch w/ pool cleanups attached.
-Paul Querna
Index: CHANGES
===
On Tue, Jun 08, 2004 at 09:58:10PM -0700, Paul Querna wrote:
> On Mon, 2004-06-07 at 21:21 +0100, Joe Orton wrote:
> > Ah, also pollset_create will need to register a cleanup now there is
> > something to clean up now I notice...
>
> pollset_destroy() ?
It's part of the deal with pools that noth
On Mon, 2004-06-07 at 21:21 +0100, Joe Orton wrote:
> On Sun, Jun 06, 2004 at 02:25:15PM -0700, Justin Erenkrantz wrote:
> > --On Sunday, June 6, 2004 1:02 AM -0700 Paul Querna <[EMAIL PROTECTED]>
> > wrote:
> >
> > >>Other than that, your patch looks sane. +1 on the concept... -- justin
> > >
On Sun, Jun 06, 2004 at 02:25:15PM -0700, Justin Erenkrantz wrote:
> --On Sunday, June 6, 2004 1:02 AM -0700 Paul Querna <[EMAIL PROTECTED]>
> wrote:
>
> >>Other than that, your patch looks sane. +1 on the concept... -- justin
> >
> >sweet.
>
> Just tested on FreeBSD 5.2.1 - looks fine. +1.
--On Sunday, June 6, 2004 1:02 AM -0700 Paul Querna <[EMAIL PROTECTED]>
wrote:
Other than that, your patch looks sane. +1 on the concept... -- justin
sweet.
Just tested on FreeBSD 5.2.1 - looks fine. +1. I'll give others a day or
so
to look at it - if no one complains, I'll commit it.
FWIW,
On Sat, 2004-06-05 at 23:23 -0700, Justin Erenkrantz wrote:
> --On Saturday, June 5, 2004 11:09 PM -0700 Paul Querna <[EMAIL PROTECTED]>
> wrote:
>
> > +// APR_POLLNVAL is not handled by epoll?
> > +// invalid FDs are automagicaly removed.
>
> You can't use C99 comments as a bunch of our
--On Saturday, June 5, 2004 11:09 PM -0700 Paul Querna <[EMAIL PROTECTED]>
wrote:
+// APR_POLLNVAL is not handled by epoll?
+// invalid FDs are automagicaly removed.
You can't use C99 comments as a bunch of our supported compilers choke on
them. Please use /* */ instead.
Other than tha
And now the Patch attached this time...
/me hits evolution
Index: configure.in
===
RCS file: /home/cvspublic/apr/configure.in,v
retrieving revision 1.585
diff -u -r1.585 configure.in
--- configure.in 5 Jun 2004 11:52:43 - 1.585
+++
Based on my work from earlier this week, I have a new Patch.
On Joe Orton's advice I removed the sys_epoll backend for apr_poll().
The more scalable platform specific backends will only be used by
apr_pollset(). As Joe explained, the extra overhead of sys_epoll or
KQueue in apr_poll() would of li
17 matches
Mail list logo
