Re: [PATCH] Use apr_get_netos_error() to get error code from getaddrinfo() function on Windows

2011-03-22 Thread Ivan Zhakov
On Mon, Mar 21, 2011 at 23:50, Jeff Trawick wrote: > On Fri, Mar 18, 2011 at 11:38 AM, Ivan Zhakov wrote: >> Hi, >> Thanks in advance. > > 1.4.x branch: http://svn.apache.org/viewvc?rev=1083949&view=rev > > also committed to trunk and 1.5.x; thanks! > Thanks a lot! -- Ivan Zhakov

Re: [PATCH] Use apr_get_netos_error() to get error code from getaddrinfo() function on Windows

2011-03-21 Thread Jeff Trawick
On Fri, Mar 18, 2011 at 11:38 AM, Ivan Zhakov wrote: > Hi, > > APR doesn't use gai_strerror() on Windows (because it's not thread > safe) and apr_streror() return "APR does not understand this code" > message for failed apr_socket_addr_get() calls. It's not user > friendly. > > Please find attache

Re: [PATCH] Use apr_get_netos_error() to get error code from getaddrinfo() function on Windows

2011-03-18 Thread Jeff Trawick
On Fri, Mar 18, 2011 at 11:38 AM, Ivan Zhakov wrote: > Hi, > > APR doesn't use gai_strerror() on Windows (because it's not thread > safe) and apr_streror() return "APR does not understand this code" > message for failed apr_socket_addr_get() calls. It's not user > friendly. > > Please find attache

[PATCH] Use apr_get_netos_error() to get error code from getaddrinfo() function on Windows

2011-03-18 Thread Ivan Zhakov
Hi, APR doesn't use gai_strerror() on Windows (because it's not thread safe) and apr_streror() return "APR does not understand this code" message for failed apr_socket_addr_get() calls. It's not user friendly. Please find attached patch to use apr_get_netos_error() to get error code from getaddr