RE: [PATCH] apr_file_mktemp should APR_CREATE the tmp file

2002-01-19 Thread sterling
On Fri, 18 Jan 2002, Ryan Bloom wrote: Yeah, I agree that it is different, but I'm not entirely sure that it is the wrong thing to do. I think if you have a temp-file, you want to delete it by *default*. Since a user can override those flags, I think it's NBD as well. -- justin

Re: [PATCH] apr_file_mktemp should APR_CREATE the tmp file

2002-01-18 Thread Justin Erenkrantz
On Tue, Jan 15, 2002 at 07:04:00PM -0800, [EMAIL PROTECTED] wrote: this patch fixes it... Also - Committed. Thanks! should it really DELONCLOSE by default? I don't think that's consistent with most implementations of mkstemp - worst case we should document it (and since the consumer can

[PATCH] apr_file_mktemp should APR_CREATE the tmp file

2002-01-16 Thread sterling
this patch fixes it... Also - should it really DELONCLOSE by default? I don't think that's consistent with most implementations of mkstemp - worst case we should document it (and since the consumer can pass their own flags its not a big deal). sterling Index: srclib/apr/file_io/unix/mktemp.c