RE: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Ryan Bloom
> From: Bill Stoddard [mailto:[EMAIL PROTECTED] > > > > This will work, and should be portable. Just a question, how big a > > performance improvement is this? Have we hit the point where we are > > optimizing code just to optimize code? > > This would be a big improvement. A shift is a -lot-

RE: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Bill Stoddard
> This will work, and should be portable. Just a question, how big a > performance improvement is this? Have we hit the point where we are > optimizing code just to optimize code? This would be a big improvement. A shift is a -lot- cheaper than a 64 bit division. We could leave apr_time_t exact

Re: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Brian Pane
[EMAIL PROTECTED] wrote: I would not support this change, simply because I don't see it making a huge difference. We are better off fixing the apr_time_t implementation and then looking for things like this. I agree. Once we go to the binary microsecond implementation, what we'll be able t

Re: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread rbb
> >I would not support this change, simply because I don't see it making a > >huge difference. We are better off fixing the apr_time_t implementation > >and then looking for things like this. > > > > I agree. Once we go to the binary microsecond implementation, > what we'll be able to do within

Re: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Brian Pane
Ryan Bloom wrote: This will work, and should be portable. Just a question, how big a performance improvement is this? Have we hit the point where we are optimizing code just to optimize code? Based on the profile data, 64-bit divisions *are* a problem, but I think there's a better solution for th

Re: [PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Ryan Bloom
This will work, and should be portable. Just a question, how big a performance improvement is this? Have we hit the point where we are optimizing code just to optimize code? I would not support this change, simply because I don't see it making a huge difference. We are better off fixing the ap

[PATCH] possible optimization in apr_poll()?

2002-07-15 Thread Aaron Bannert
Is this at all portable? I'm making the approximation that n>>10 is about the same as a /1000, and since apr_poll() isn't guaranteed to be that accurate, this should be a good chance for an optimization, right? -aaron Index: srclib/apr/poll/unix/poll.c ===