This patch is seg faulting the test suite. I'll look into it, but this may be a
problem with the reference concept and apr_pollset_add. The problem is that you
can create the apr_pollfd_t on the stack, which means that the ref field may not
be initialized. This is what is causing the segfault,
This is on my list of things to look at. I have done a very quick cursory scan
of the patch, but I haven't really looked at it yet. The problem is I just
started a new job, and I am still trying to work out when I have time to code
outside of work.
I'll try to look at this tonight or this weeke
[ Resending - I gotta get this moving soon. Patch is attached. ]
> You're probably right. I'll see about getting an updated patch that
> incorporates these changes.
OK, I've put together a new patch that implements the both the
optimisation and the simpler _pollset_update() method.
Attached to b
> You're probably right. I'll see about getting an updated patch that
> incorporates these changes.
OK, I've put together a new patch that implements the both the
optimisation and the simpler _pollset_update() method.
Attached to bug 27655:
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=276
On Mon, Mar 15, 2004 at 10:11:09AM -0800, [EMAIL PROTECTED] wrote:
> 1) This patch isn't complete. At the very least we need a patch to the
> header
> that includes doxygen comments that document this new API. Preferably, a new
> patch would also include a patch to testpoll to test this feature
At 02:15 AM 3/14/2004, Robert Norris wrote:
>Attached is a patch that adds a function apr_pollset_update(). This
>updates the list of requested events for the descriptor in the
>underlying implementation for a descriptor that is already in a pollset.
>...
>The optimisation that I'd like to do is to
A couple of comments:
1) This patch isn't complete. At the very least we need a patch to the header
that includes doxygen comments that document this new API. Preferably, a new
patch would also include a patch to testpoll to test this feature. It should
also include a stub function in all non-
Robert Norris wrote:
Robert,
Thanks for resending... No promises but I'll try to review this this week.
Please, someone beat me to it.
Bill
[ I'm resending this, because I didn't get any responses to it the first
time. ]
Attached is a patch that adds a function apr_pollset_update(). This
updates t
[ I'm resending this, because I didn't get any responses to it the first
time. ]
Attached is a patch that adds a function apr_pollset_update(). This
updates the list of requested events for the descriptor in the
underlying implementation for a descriptor that is already in a pollset.
It works wel
