On 3/28/20 11:35 AM, Graham Leggett wrote:
> On 27 Mar 2020, at 21:20, Ruediger Pluem wrote
> :
>> Why are functions that are supposed to be static in the apr_ namespace?
>> IMHO this is confusing when reading code.
>
> Are you asking the actual question why, or are you just pointing out that
On 27 Mar 2020, at 21:20, Ruediger Pluem wrote
:
> Why are functions that are supposed to be static in the apr_ namespace?
> IMHO this is confusing when reading code.
Are you asking the actual question why, or are you just pointing out that they
shouldn’t be in the apr_ namespace?
Regards,
On 3/27/20 12:07 PM, Graham Leggett wrote:
> On 27 Mar 2020, at 10:48, Joe Orton wrote:
>
>> I assume all these functions should be declared static but haven't
>> looked at the code. branches/1.7.x as at r1875766 -
>
> If they’re not in the header file they should be static, yes.
Why are
On 27 Mar 2020, at 10:48, Joe Orton wrote:
> I assume all these functions should be declared static but haven't
> looked at the code. branches/1.7.x as at r1875766 -
If they’re not in the header file they should be static, yes.
Cut and paste is fun.
Regards,
Graham
—
smime.p7s
On 3/27/20 9:48 AM, Joe Orton wrote:
> I assume all these functions should be declared static but haven't
> looked at the code. branches/1.7.x as at r1875766 -
>
> jose/apr_jose_decode.c:21:14: warning: no previous prototype for
> ‘apr_jose_flatten’ [-Wmissing-prototypes]
>21 |
I assume all these functions should be declared static but haven't
looked at the code. branches/1.7.x as at r1875766 -
jose/apr_jose_decode.c:21:14: warning: no previous prototype for
‘apr_jose_flatten’ [-Wmissing-prototypes]
21 | apr_status_t apr_jose_flatten(apr_bucket_brigade *bb,
