Re: apr_lstat() fails on linux for large files

2003-03-01 Thread Wan-Teh Chang
Justin Erenkrantz wrote: > > > something we can fix for APR 1.0/Apache 2.1-dev by making apr_off_t always > > 64 bits whether native apr_off_t is 64 bits or not? > > Perhaps that might not be a bad idea, but it would make off_t usage that much > worse on 32-bit processors and we'd have to downcast

Re: apr_lstat() fails on linux for large files

2003-03-01 Thread Justin Erenkrantz
[ Moving to [EMAIL PROTECTED] ] --On Friday, February 28, 2003 4:37 PM -0500 Jeff Trawick <[EMAIL PROTECTED]> wrote: > (a) Why doesn't Apache automatically include largefile support? > Performance reasons? Shouldn't there at least be an easy ./configure > option to turn it on? isn't there also t

Re: apr_lstat() fails on linux for large files

2003-03-01 Thread Jeff Trawick
William A. Rowe, Jr. wrote: At 03:37 PM 2/28/2003, Jeff Trawick wrote: >something we can fix for APR 1.0/Apache 2.1-dev by making apr_off_t always 64 bits +1 >whether native apr_off_t is 64 bits or not? s/apr_off_t/off_t/ :-) oops :) yes, of course that was the intention

Re: apr_lstat() fails on linux for large files

2003-02-28 Thread William A. Rowe, Jr.
At 02:11 PM 2/28/2003, Cliff Woolley wrote: >On Fri, 28 Feb 2003, William A. Rowe, Jr. wrote: > >> Short of turning on largefile support here and now, what about a simple >> APR hack? Keep an overflow flag for apr_dir_t, and when the lstat() >> call from apr_dir_read returns EOVERFLOW, set that fl

Re: apr_lstat() fails on linux for large files

2003-02-28 Thread William A. Rowe, Jr.
At 05:10 PM 2/28/2003, Joe Orton wrote: >Yeah, something like that is possible: if you build with >-D_LARGEFILE_SOURCE you get the "transitional" LFS API which gives you >open64 (aka passing O_LARGEFILE to open) and lseek64 and things like >that which work on a new off64_t type, without changing t

Re: apr_lstat() fails on linux for large files

2003-02-28 Thread William A. Rowe, Jr.
At 03:37 PM 2/28/2003, Jeff Trawick wrote: >Joe Orton wrote: > >>On Fri, Feb 28, 2003 at 02:23:31PM -0500, Cliff Woolley wrote: >>... >> >>>Of course, if I go and explictly compile Apache with >>>CFLAGS=-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64, then it works. >>> >>>So I guess the ultimate questi

Re: apr_lstat() fails on linux for large files

2003-02-28 Thread Cliff Woolley
On Fri, 28 Feb 2003, William A. Rowe, Jr. wrote: > Short of turning on largefile support here and now, what about a simple > APR hack? Keep an overflow flag for apr_dir_t, and when the lstat() > call from apr_dir_read returns EOVERFLOW, set that flag but loop and > grab the next legal file. Work

Re: apr_lstat() fails on linux for large files

2003-02-28 Thread William A. Rowe, Jr.
Please don't make Linux's problem every APR user's headache, such as autoindex you describe below. Short of turning on largefile support here and now, what about a simple APR hack? Keep an overflow flag for apr_dir_t, and when the lstat() call from apr_dir_read returns EOVERFLOW, set that flag bu