Ben Laurie wrote:
BTW, on the subject of bitfield gotchas, never make boolean fields
signed - why? Coz:
struct x { signed int onebitfield:1; } x;
signed int someint;
x.onebitfield=TRUE;
someint=TRUE;
assert(x.onebitfield == someint); /* SPLAT!!! */
:)
[EMAIL PROTECTED] wrote:
> trawick 2003/11/06 08:26:09
>
> Modified:random/unix apr_random.c
> Log:
> fix an odd portability issue:
>
> Bit-field foo must be of type signed int, unsigned int or int.
Thanks.
BTW, on the subject of bitfield gotchas, never make boolean fields
sig
On Wed, Nov 05, 2003 at 11:32:07PM +, Ben Laurie wrote:
> Branko Äibej wrote:
>
> > Ben Laurie wrote:
> >
> >
> >>Jeff Trawick wrote:
> >>
> >>
> >>
> >>>/* FIXME: this is not C99 or C++ or Java */
> >>>
> >>>
> >>
> >>What's the matter? Did your editor break? :-)
> >>
> >>Besides, y
Branko Äibej wrote:
> Ben Laurie wrote:
>
>
>>Jeff Trawick wrote:
>>
>>
>>
>>>/* FIXME: this is not C99 or C++ or Java */
>>>
>>>
>>
>>What's the matter? Did your editor break? :-)
>>
>>Besides, your revision is wrong...
>>
>> /* FIXME: this is not C99 or C++ or Java or gcc */
>>
>>
Ben Laurie wrote:
>Jeff Trawick wrote:
>
>
>> /* FIXME: this is not C99 or C++ or Java */
>>
>>
>
>What's the matter? Did your editor break? :-)
>
>Besides, your revision is wrong...
>
> /* FIXME: this is not C99 or C++ or Java or gcc */
>
>
So now 'gcc' is a language. Sigh.
Try
Ben Laurie wrote:
Jeff Trawick wrote:
[EMAIL PROTECTED] wrote:
ben 2003/11/05 03:59:54
Code style.
compilability is another issue ;)
Index: apr_random.h
===
RCS file: /home/cvs/apr/include/apr_random.h,v
retrieving re
Jeff Trawick wrote:
> [EMAIL PROTECTED] wrote:
>
>> ben 2003/11/05 03:59:54
>
>
>> Code style.
>
>
> compilability is another issue ;)
>
>> Index: apr_random.h
>> ===
>> RCS file: /home/cvs/apr/include/apr_random
[EMAIL PROTECTED] wrote:
ben 2003/11/05 03:59:54
Code style.
compilability is another issue ;)
Index: apr_random.h
===
RCS file: /home/cvs/apr/include/apr_random.h,v
retrieving revision 1.2
retrieving revision 1.3
