Re: cvs commit: apr/test testhash.c

I'll add some tests to the test program tonight to catch stuff like this. Ryan Quoting Joe Orton <[EMAIL PROTECTED]>: > This broke apr_hash_{merge,overlay}; I've checked in a minimal fix to > stop httpd segfaulting everywhere, but presumable it needs a doc string > update as below, unless behav

Re: cvs commit: apr/test testhash.c

This broke apr_hash_{merge,overlay}; I've checked in a minimal fix to stop httpd segfaulting everywhere, but presumable it needs a doc string update as below, unless behaviour for merging two hash tables with different hash functions can be defined: --- include/apr_hash.h 18 Apr 2004 12:12:49 -00

Re: cvs commit: apr/test testhash.c

--- André Malo <[EMAIL PROTECTED]> wrote: > oh well. Though I don't find that pointer hiding not > very intuitive I agree with you in general, but I think it's by far the most common idiom for function pointers. It doesn't really matter which syntax you choose, but you should be consistent thro

Re: cvs commit: apr/test testhash.c

* [EMAIL PROTECTED] wrote: > I've never seen function pointer types defined that way. Heh, httpd does it all the time ;-) > The biggest > problem is that this type can't be used without a * in front of the > variable. Not a big deal, but it does make the type less usefull. that's right. but ma

Re: cvs commit: apr/test testhash.c

Quoting André Malo <[EMAIL PROTECTED]>: > * [EMAIL PROTECTED] wrote: > > > Quoting André Malo <[EMAIL PROTECTED]>: > > > > > * André Malo <[EMAIL PROTECTED]> wrote: > > > > > > > APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > > > >

Re: cvs commit: apr/test testhash.c

* [EMAIL PROTECTED] wrote: > Quoting André Malo <[EMAIL PROTECTED]>: > > > * André Malo <[EMAIL PROTECTED]> wrote: > > > > > APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > > > apr_hashfunc_t > > >

Re: cvs commit: apr/test testhash.c

Quoting André Malo <[EMAIL PROTECTED]>: > * André Malo <[EMAIL PROTECTED]> wrote: > > > APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > > apr_hashfunc_t hash_func) > > Additionally hash_func should be a pointer (also in declarat

Re: cvs commit: apr/test testhash.c

I fixed this. I thought I had re-compiled after my changes, but I must have just been in the test directory when I did it. Ryan Quoting André Malo <[EMAIL PROTECTED]>: > * [EMAIL PROTECTED] wrote: > > > +APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > > +

Re: cvs commit: apr/test testhash.c

* André Malo <[EMAIL PROTECTED]> wrote: > APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > apr_hashfunc_t hash_func) Additionally hash_func should be a pointer (also in declaration in in the hash struct), shouldn't it? nd -- Tre

Re: cvs commit: apr/test testhash.c

* [EMAIL PROTECTED] wrote: > +APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > + apr_hashfunc_t hash_func) > +{ > +ht = apr_hash_make(p); > +ht->hash_func = hash_func; >return ht; >} > I've thought t