Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread Joe Orton
On Fri, Mar 21, 2003 at 01:56:52PM -0600, William Rowe wrote: > At 01:09 PM 3/21/2003, Jeff Trawick wrote: > > >I'm a bit nervous about the existing/new special handling for descriptors > >0-2. > > Ok, here is a patch that uses the target file's inherit and noclose > flag bits for apr_file_dup2(

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread William A. Rowe, Jr.
At 02:36 PM 3/21/2003, Jeff Trawick wrote: >>>Why isn't the problem this: >>> >>>Apache opened stderr from the wrong pool, or failed to open it again when >>>the original pool for stderr was cleaned up; in other words, it was cleaned >>>up because of a pool lifetime problem in the application, no

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread Jeff Trawick
William A. Rowe, Jr. wrote: At 01:09 PM 3/21/2003, Jeff Trawick wrote: I'm a bit nervous about the existing/new special handling for descriptors 0-2. Are you looking at my original or new patch? either I won't disagree, if you want apr_file_dup() to always return an uninherited handle, that isn't

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread William A. Rowe, Jr.
At 01:09 PM 3/21/2003, Jeff Trawick wrote: >I'm a bit nervous about the existing/new special handling for descriptors 0-2. Ok, here is a patch that uses the target file's inherit and noclose flag bits for apr_file_dup2(), and leaves apr_file_dup() results as never inherited and always registering

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread William A. Rowe, Jr.
At 01:09 PM 3/21/2003, Jeff Trawick wrote: >I'm a bit nervous about the existing/new special handling for descriptors 0-2. Are you looking at my original or new patch? I won't disagree, if you want apr_file_dup() to always return an uninherited handle, that isn't a problem. Just look in the whi

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread Jeff Trawick
William A. Rowe, Jr. wrote: At 10:48 AM 3/21/2003, Jeff Trawick wrote: backtracking uses of fd 2 up through this time is somewhat funny it looks like a) we set the error log to file descriptor 2 b) we close file descriptor 2 and set it to /dev/null via the freopen() in apr_proc_detach c) we close

Re: cvs commit: httpd-2.0/server/mpm/worker pod.c

2003-03-21 Thread William A. Rowe, Jr.
At 10:48 AM 3/21/2003, Jeff Trawick wrote: >Joe Orton wrote: >> >>In the r1.57 filedup.c change, a cleanup is registered for the "new" >>fd coming out of apr_file_dup2(), which wasn't happening previously. >>I'm guessing that this cleanup is closing fd 2 when pconf is cleared, or >>something li