Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-10 Thread Tom Donovan
On 3/9/2011 1:54 PM, William A. Rowe Jr. wrote: On 3/9/2011 12:40 PM, Jeff Trawick wrote: The original code was a bit disturbing because of the indentation: /* mark all the columns as needing SQLGetData unless they are bound */ for (c = 0; c res-ncols; c++) { if

Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-10 Thread Tom Donovan
On 3/9/2011 1:54 PM, William A. Rowe Jr. wrote: On 3/9/2011 12:40 PM, Jeff Trawick wrote: The original code was a bit disturbing because of the indentation: My 2nd try is change 1080404. I guess I've become a bit rusty at this! -tom-

Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-09 Thread Jeff Trawick
On Sun, Mar 6, 2011 at 11:34 AM, traw...@apache.org wrote: Author: trawick Date: Sun Mar  6 16:34:46 2011 New Revision: 1078507 URL: http://svn.apache.org/viewvc?rev=1078507view=rev Log: style changes only -- make it look a lot more like the bulk of APR Modified:    

Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c

2011-03-09 Thread William A. Rowe Jr.
On 3/9/2011 12:40 PM, Jeff Trawick wrote: The original code was a bit disturbing because of the indentation: /* mark all the columns as needing SQLGetData unless they are bound */ for (c = 0; c res-ncols; c++) { if (res-colstate[c] != COL_BOUND)