Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-21 Thread Ruediger Pluem
On 10/20/21 11:01 PM, Graham Leggett wrote: > On 20 Oct 2021, at 10:43, Yann Ylavic wrote: > >> apr_strnstr() maybe, strnstr() is non-standard AFAICT and possibly not >> available on all platforms (Windows)? > > This needs to be memmem really, as the boundary isn’t always a string. But I

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-20 Thread Yann Ylavic
On Wed, Oct 20, 2021 at 11:01 PM Graham Leggett wrote: > > On 20 Oct 2021, at 10:43, Yann Ylavic wrote: > >> apr_strnstr() maybe, strnstr() is non-standard AFAICT and possibly not >> available on all platforms (Windows)? > > This needs to be memmem really, as the boundary isn’t always a string.

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-20 Thread Graham Leggett
On 20 Oct 2021, at 10:43, Yann Ylavic wrote: > apr_strnstr() maybe, strnstr() is non-standard AFAICT and possibly not > available on all platforms (Windows)? This needs to be memmem really, as the boundary isn’t always a string. Memmem is non portable and old versions are buggy. Is there

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-20 Thread Yann Ylavic
On Tue, Oct 19, 2021 at 4:31 PM wrote: > > --- apr/apr/trunk/include/apr_buckets.h (original) > +++ apr/apr/trunk/include/apr_buckets.h Tue Oct 19 14:30:37 2021 > @@ -53,6 +53,11 @@ extern "C" { > /** default bucket buffer size - 8KB minus room for memory allocator headers > */ > #define

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-20 Thread Yann Ylavic
For instance there is [1] in apreq that also splits a brigade on a boundary. [1] https://github.com/apache/apreq/blob/trunk/library/parser_multipart.c#L112 Regards; Yann. On Wed, Oct 20, 2021 at 11:43 AM Yann Ylavic wrote: > > On Tue, Oct 19, 2021 at 4:31 PM wrote: > > > >

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

2021-10-20 Thread Yann Ylavic
On Tue, Oct 19, 2021 at 4:31 PM wrote: > > +APR_DECLARE(apr_status_t) apr_brigade_split_boundary(apr_bucket_brigade > *bbOut, > + apr_bucket_brigade > *bbIn, > + apr_read_type_e block, > +