Re: testdup test fails when compiled in debug mode on Windows

2013-11-07 Thread Jeff Trawick
On Thu, Nov 7, 2013 at 12:33 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Wed, 06 Nov 2013 16:07:37 -0800 Mike Rumph mike.ru...@oracle.com wrote: On 11/6/2013 1:06 PM, Jeff Trawick wrote: I just played with _commit() on stdin a bit. It turns out that _commit(0) fails if

Re: testdup test fails when compiled in debug mode on Windows

2013-11-07 Thread Mike Rumph
Hello Bill, That is a very good point, since the assert box will only appear under debug mode. But when not in debug mode _commit(2) will send back a -1 return code and set errno to EBADF, if stderr is not redirected to a file. The error existed in both cases, but the apr_file_dup2()

Re: testdup test fails when compiled in debug mode on Windows

2013-11-07 Thread William A. Rowe Jr.
On Thu, 7 Nov 2013 09:43:07 -0500 Jeff Trawick traw...@gmail.com wrote: On Thu, Nov 7, 2013 at 12:33 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Wed, 06 Nov 2013 16:07:37 -0800 Mike Rumph mike.ru...@oracle.com wrote: On 11/6/2013 1:06 PM, Jeff Trawick wrote: I

Re: testdup test fails when compiled in debug mode on Windows

2013-11-07 Thread Jeff Trawick
On Thu, Nov 7, 2013 at 11:20 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Thu, 7 Nov 2013 09:43:07 -0500 Jeff Trawick traw...@gmail.com wrote: On Thu, Nov 7, 2013 at 12:33 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: On Wed, 06 Nov 2013 16:07:37 -0800 Mike Rumph

testdup test fails when compiled in debug mode on Windows

2013-11-06 Thread Mike Rumph
The apr_file_dup2() function in apr/file_io/win32/filedup.c calls _commit() for standard file handles 0, 1 and 2. The _commit() function will assert with the message Invalid file descriptor. File possibly closed by a different thread or return a value of -1 if the file handle refers to a

Re: testdup test fails when compiled in debug mode on Windows

2013-11-06 Thread Jeff Trawick
On Wed, Nov 6, 2013 at 2:06 PM, Mike Rumph mike.ru...@oracle.com wrote: The apr_file_dup2() function in apr/file_io/win32/filedup.c calls _commit() for standard file handles 0, 1 and 2. The _commit() function will assert with the message Invalid file descriptor. File possibly closed by a

Re: testdup test fails when compiled in debug mode on Windows

2013-11-06 Thread Jeff Trawick
On Wed, Nov 6, 2013 at 2:13 PM, Jeff Trawick traw...@gmail.com wrote: On Wed, Nov 6, 2013 at 2:06 PM, Mike Rumph mike.ru...@oracle.com wrote: The apr_file_dup2() function in apr/file_io/win32/filedup.c calls _commit() for standard file handles 0, 1 and 2. The _commit() function will assert

Re: testdup test fails when compiled in debug mode on Windows

2013-11-06 Thread Mike Rumph
On 11/6/2013 1:06 PM, Jeff Trawick wrote: I just played with _commit() on stdin a bit. It turns out that _commit(0) fails if stdin is redirected (main.exe somefile) but works if stdin is a tty. That's the opposite of _commit(1 or 2). But I don't see how _commit(0) makes sense anyway, so

Re: testdup test fails when compiled in debug mode on Windows

2013-11-06 Thread William A. Rowe Jr.
On Wed, 06 Nov 2013 16:07:37 -0800 Mike Rumph mike.ru...@oracle.com wrote: On 11/6/2013 1:06 PM, Jeff Trawick wrote: I just played with _commit() on stdin a bit. It turns out that _commit(0) fails if stdin is redirected (main.exe somefile) but works if stdin is a tty. That's the