Re: [C++] Private implementations and virtual interfaces

2019-07-28 Thread Antoine Pitrou
Hi, Le 27/07/2019 à 21:04, Wes McKinney a écrit : > * My understanding is that the PIMPL pattern will perform better for > non-virtual functions that are called a lot. It'd be helpful to know > the magnitude of the performance difference Modern CPUs have indirect branch predictors. If an indir

Re: [C++] Private implementations and virtual interfaces

2019-07-28 Thread Antoine Pitrou
Le 28/07/2019 à 01:49, Wes McKinney a écrit : > On Sat, Jul 27, 2019 at 4:38 PM Uwe L. Korn wrote: >> >> The PIMPL is a thing I would trade a bit of performance as it brings ABI >> stability. This is something that will help us making Arrow usage in >> thirdparty code much simpler. >> > > I q

Re: [C++] Private implementations and virtual interfaces

2019-07-28 Thread Uwe L. Korn
Building CI that detects ABI breakage is not hard. There is a closed PR in the arrow repo from me that does exactly this using abi-complicance-checker. I understand that we will not be able to provide ABI stability on all Arrow subprojects but having it for a core would be really great. This wou

Parquet to Arrow in Java

2019-07-28 Thread Anoop Johnson
Arrow Newbie here. What is the recommended way to convert Parquet data into Arrow, preferably doing predicate/column pushdown? One can implement this as custom code using the Parquet API, and re-encode it in Arrow using the Arrow APIs, but is this supported by Arrow out of the box? Thanks, Anoop