Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Fan Liya
Congratulations, Ben! Best, Liya Fan On Fri, May 7, 2021 at 4:23 AM Bryan Cutler wrote: > Congrats Ben! > > On Thu, May 6, 2021 at 12:05 PM Antoine Pitrou wrote: > > > > > Congratulations Ben :-) > > > > > > Le 06/05/2021 à 21:02, Rok Mihevc a écrit : > > > Congrats! > > > > > > On Thu, May 6,

Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Bryan Cutler
Congrats Ben! On Thu, May 6, 2021 at 12:05 PM Antoine Pitrou wrote: > > Congratulations Ben :-) > > > Le 06/05/2021 à 21:02, Rok Mihevc a écrit : > > Congrats! > > > > On Thu, May 6, 2021 at 10:49 AM Krisztián Szűcs < > szucs.kriszt...@gmail.com> > > wrote: > > > >> Congrats Ben! > >> > >> On Th

Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Antoine Pitrou
Congratulations Ben :-) Le 06/05/2021 à 21:02, Rok Mihevc a écrit : Congrats! On Thu, May 6, 2021 at 10:49 AM Krisztián Szűcs wrote: Congrats Ben! On Thu, May 6, 2021 at 9:20 AM Joris Van den Bossche wrote: Congrats! On Thu, 6 May 2021 at 07:03, Weston Pace wrote: Congratulations

Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Rok Mihevc
Congrats! On Thu, May 6, 2021 at 10:49 AM Krisztián Szűcs wrote: > Congrats Ben! > > On Thu, May 6, 2021 at 9:20 AM Joris Van den Bossche > wrote: > > > > Congrats! > > > > On Thu, 6 May 2021 at 07:03, Weston Pace wrote: > > > > > Congratulations Ben! > > > > > > On Wed, May 5, 2021 at 6:48 PM

Re: [VOTE] Register media types (MIME types) for Apache Arrow formats to IANA

2021-05-06 Thread Rok Mihevc
+1 (non-binding) On Thu, May 6, 2021 at 6:32 PM Wes McKinney wrote: > +1 (binding) > > On Wed, May 5, 2021 at 9:25 AM Kazuaki Ishizaki > wrote: > > > > +1, great > > > > Weston Pace wrote on 2021/05/04 20:41:34: > > > > > From: Weston Pace > > > To: dev@arrow.apache.org > > > Date: 2021/05/04

Re: [C++] Adopting a library for (distributed) tracing

2021-05-06 Thread David Li
I've created ARROW-12671 [1] to track this work and filed a draft PR [2]; I'd appreciate any feedback, particularly from anyone already trying to use OpenTelemetry/Tracing/Census with Arrow. For dependencies: now we use OpenTelemetry as header-only by default. I also slimmed down the build, avoidi

Re: [VOTE] Register media types (MIME types) for Apache Arrow formats to IANA

2021-05-06 Thread Wes McKinney
+1 (binding) On Wed, May 5, 2021 at 9:25 AM Kazuaki Ishizaki wrote: > > +1, great > > Weston Pace wrote on 2021/05/04 20:41:34: > > > From: Weston Pace > > To: dev@arrow.apache.org > > Date: 2021/05/04 20:41 > > Subject: [EXTERNAL] [VOTE] Register media types (MIME types) for > > Apache Arrow f

Re: Re: [Format][RFC] Introduce COMPLEX type for IntervalUnit

2021-05-06 Thread Wes McKinney
Ah, that makes sense to wait then. On Thu, May 6, 2021 at 10:55 AM Micah Kornfield wrote: > > I'll address the feedback. I think in the past we've waited for > implementations in java and c++ with integration tests before formally > voting. If there is no more feedback I can start looking at

Re: Re: [Format][RFC] Introduce COMPLEX type for IntervalUnit

2021-05-06 Thread Micah Kornfield
I'll address the feedback. I think in the past we've waited for implementations in java and c++ with integration tests before formally voting. If there is no more feedback I can start looking at implementations (happy to have help) On Thursday, May 6, 2021, Wes McKinney wrote: > The PR looks g

Re: [Format][RFC] Introduce COMPLEX type for IntervalUnit

2021-05-06 Thread Wes McKinney
The PR looks good. I just left some comments about typos. I would say it's probably about time to call a vote. Anywhere else where we should be soliciting feedback? On Mon, May 3, 2021 at 2:17 PM Jacek Pliszka wrote: > > Good idea, I've created JIRA issue: > > https://issues.apache.org/jira/brows

Re: Code base visitor pattern help

2021-05-06 Thread Wes McKinney
What are you trying to do? You can look at various usages of VisitArrayInline (inline / non-virtual visitor) or the corresponding ArrayVisitor virtual interface which is used elsewhere where it makes sense https://github.com/apache/arrow/search?q=VisitArrayInline we use SFINAE / std::enable_if q

Code base visitor pattern help

2021-05-06 Thread Niranda Perera
Hi all, I am following the latest arrow c++ code base and I figured that visitor pattern is extensively used there. When I go through the code naively, I sometimes get immersed in templates and preprocessor directives. :D Could you give some pointers to start on the impl, especially in the arrow c

[NIGHTLY] Arrow Build Report for Job nightly-2021-05-06-0

2021-05-06 Thread Crossbow
Arrow Build Report for Job nightly-2021-05-06-0 All tasks: https://github.com/ursacomputing/crossbow/branches/all?query=nightly-2021-05-06-0 Failed Tasks: - conda-linux-gcc-py36-arm64: URL: https://github.com/ursacomputing/crossbow/branches/all?query=nightly-2021-05-06-0-drone-conda-linux-g

Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Krisztián Szűcs
Congrats Ben! On Thu, May 6, 2021 at 9:20 AM Joris Van den Bossche wrote: > > Congrats! > > On Thu, 6 May 2021 at 07:03, Weston Pace wrote: > > > Congratulations Ben! > > > > On Wed, May 5, 2021 at 6:48 PM Micah Kornfield > > wrote: > > > > > Congrats! > > > > > > On Wed, May 5, 2021 at 4:33 PM

Re: [ANNOUNCE] New Arrow PMC member: Benjamin Kietzman

2021-05-06 Thread Joris Van den Bossche
Congrats! On Thu, 6 May 2021 at 07:03, Weston Pace wrote: > Congratulations Ben! > > On Wed, May 5, 2021 at 6:48 PM Micah Kornfield > wrote: > > > Congrats! > > > > On Wed, May 5, 2021 at 4:33 PM David Li wrote: > > > > > Congrats Ben! Well deserved. > > > > > > Best, > > > David > > > > > > O