Re: [DISCUSS] Revisiting LZ4 Compression for Arrow Buffers

2021-03-22 Thread Benjamin Wilhelm
sion as > this will be a proper subset of LZ4 compression. > > Could you share the benchmark code/how the benchmark was run (does this > account for JIT warm-up time)? > > -Micah > > On Mon, Mar 22, 2021 at 7:46 AM Antoine Pitrou wrote: > > > > > Le 22/03/2021

Re: [DISCUSS] Revisiting LZ4 Compression for Arrow Buffers

2021-03-22 Thread Benjamin Wilhelm
ent themselves), > so for something as core to the specification as this, ease of use is also > a consideration. > > It looks like lz4-java might just checkin the native shared libraries into > the repo, which is not an approach I'd like to take within Arrow. > > > On Thu

Re: [DISCUSS] Revisiting LZ4 Compression for Arrow Buffers

2021-03-18 Thread Benjamin Wilhelm
> > > 1) contribute the missing support ourselves > I actually think we might need to proceed with this option. I agree. I am willing to help with this and explore and try different approaches. I would start looking into the JNI approach. Contributing back to lz4-java or adding this to Arrow. Be

[JIRA Permissions] Assigning myself to ARROW-11901

2021-03-18 Thread Benjamin Wilhelm
Hi all, I would like to contribute to Arrow by working on the performance issues with the newly introduced LZ4 compression in Java (JIRA: https://issues.apache.org/jira/browse/ARROW-11901). Can someone make me a "Contributor" in JIRA so I can assign myself? Thank you! Benjamin Wilhelm

Re: [Java] ArrowBuf bounds checking in getBytes/setBytes

2020-10-17 Thread Benjamin Wilhelm
Thank you Liya, I will try to implement some benchmarks to see how much it impacts the performance for different numbers of bytes set each time. If I find enough evidence that bounds checking can hurt the performance I will open a PR. Best, Benjamin Wilhelm On 15.10.20 14:07, Fan Liya

[Java] ArrowBuf bounds checking in getBytes/setBytes

2020-10-15 Thread Benjamin Wilhelm
constant and always check the bounds. What is the reason for this? Wouldn't it make sense if each method respects this constant? Thank you! Benjamin Wilhelm