Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2022-01-04 Thread David Li
Hey James - thanks for the reminder, sorry for dropping the ball here. I think you can submit a PR to arrow-site: https://github.com/apache/arrow-site and we can iterate/review it from there. Thanks, David On Tue, Jan 4, 2022, at 12:25, James Duong wrote: > If I recall correctly, there was inte

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2022-01-04 Thread James Duong
If I recall correctly, there was interest in providing a blog post to accompany the announcement of Flight SQL's release. Where should this be submitted and what other steps would be needed for this? On Sat, Dec 25, 2021 at 8:07 PM Jacques Nadeau wrote: > That's great news. Congrats and thanks t

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-25 Thread Jacques Nadeau
That's great news. Congrats and thanks to the team who worked on it. This is a great addition to Arrow! On Thu, Dec 23, 2021, 11:26 AM David Li wrote: > The integration tests and existing PRs were merged into a separate branch. > We also merged in a few build fixes during final review. Just in t

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-23 Thread David Li
The integration tests and existing PRs were merged into a separate branch. We also merged in a few build fixes during final review. Just in time for the holidays, Flight SQL has now been merged into the main branch, thanks again to everyone who participated! I will begin reviewing the additiona

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-17 Thread James Duong
Yes, additional metadata would just be using the Field metadata map. The protocol is the same, we have just pre-defined keys for some fields that would be used for JDBC column attributes. Our preference would be that we get the currently approved protocol merged into master first (after completing

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-16 Thread David Li
Strictly speaking we should have a vote since it is updating the format definition files we already voted on. I am curious about what exactly you mean by additional column metadata, but if it's just going to be encoded into the key-value metadata then I don't see a problem there. (As in: it so

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-16 Thread James Duong
Hi David, While working on the JDBC driver on top of Flight SQL and on integration tests, we identified a couple of enhancements that were needed. 1. The ability to report data type information, as done in this PR: https://github.com/apache/arrow/pull/11982. This PR adds another RPC request for th

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-16 Thread Kyle Porter
Thanks All - we'll look to get the tests merged into this branch so we can close ASAP. *Kyle Porter* CEO Bit Quill Technologies Inc. Office: +1.778.331.3355 | Direct: +1.604.441.7318 | ky...@bitquilltech.com https://www.bitquill.com This email message is for the sole use of the intended recipient

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-15 Thread David Li
Great. I've merged both your PRs into the new branch, so you can open a PR for the integration tests against that branch next. -David On Wed, Dec 15, 2021, at 13:52, Rafael Telles wrote: > Thanks everyone! > > @David, we prefer to already merge the existing PRs and then add the > integration te

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-15 Thread Rafael Telles
Thanks everyone! @David, we prefer to already merge the existing PRs and then add the integration tests as soon as possible. Em qua., 15 de dez. de 2021 às 11:11, David Li escreveu: > My vote: +1 > > The vote passes with three +1 (binding) votes, one +1 (non binding) vote, > and one -0.5 (bindi

Re: [RESULT][VOTE] Proposed addition to Arrow Flight: Arrow Flight RPC

2021-12-15 Thread David Li
My vote: +1 The vote passes with three +1 (binding) votes, one +1 (non binding) vote, and one -0.5 (binding) vote. However, we will first merge into a separate branch and implement integration tests before merging into the main branch. JIRA for integration tests: https://issues.apache.org/jira