Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Eric Burden
Thanks! On Tue, Mar 2, 2021 at 5:02 PM Andrew Lamb wrote: > You need to be added to a separate list -- I will take care of it. Thank > you! > > On Tue, Mar 2, 2021 at 5:18 PM Eric Burden > wrote: > > > I've created the JIRA issue, how do I assign it to myself? > > > > On Tue, Mar 2, 2021 at 3:5

Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Andrew Lamb
You need to be added to a separate list -- I will take care of it. Thank you! On Tue, Mar 2, 2021 at 5:18 PM Eric Burden wrote: > I've created the JIRA issue, how do I assign it to myself? > > On Tue, Mar 2, 2021 at 3:59 PM Andrew Lamb wrote: > > > Thanks Eric! A JIRA issue and PR would be most

Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Eric Burden
I've created the JIRA issue, how do I assign it to myself? On Tue, Mar 2, 2021 at 3:59 PM Andrew Lamb wrote: > Thanks Eric! A JIRA issue and PR would be most appreciated ! If you need > help, just let us know > > Andrew > > On Tue, Mar 2, 2021 at 4:24 PM Eric Burden > wrote: > > > Having dug in

Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Andrew Lamb
Thanks Eric! A JIRA issue and PR would be most appreciated ! If you need help, just let us know Andrew On Tue, Mar 2, 2021 at 4:24 PM Eric Burden wrote: > Having dug into it a bit, I think I've identified the issue here[1]. This > would be my first time contributing to Arrow, should I create an

Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Eric Burden
Having dug into it a bit, I think I've identified the issue here[1]. This would be my first time contributing to Arrow, should I create an issue on JIRA first before starting in on it? [1] https://docs.rs/arrow/3.0.0/src/arrow/array/array_primitive.rs.html#242-271 On Tue, Mar 2, 2021 at 1:03 PM

Re: [Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Andrew Lamb
It seems to me the panic on printing out the array is a bug. I think the code should have either errored out in the builder (date_32_builder.append_value()) or passed successfully. It wasn't immediately clear to me from the arrow format definition[1] envisions signed integers, but the rust code u

[Rust] Debug printing Date32Array panics for negative values

2021-03-02 Thread Eric Burden
As it says on the subject line. I encountered this issue attempting to store dates prior to the epoch (1970-01-01). I checked for an issue in JIRA and GitHub, but I didn't see anything related and wanted to raise it as a discussion before I filed an issue. MRE: fn test_date32_builder() { let