Re: [RESULT][VOTE] C++: switch to C++17

2022-08-31 Thread Antoine Pitrou
Hi Sasha, It's tracked at https://issues.apache.org/jira/browse/ARROW-17110 There's an initial PR at https://github.com/apache/arrow/pull/13991 Regards Antoine. Le 31/08/2022 à 00:25, Sasha Krassovsky a écrit : Hi, What kind of timeline did we decide on? Is this something that can be work

Re: [RESULT][VOTE] C++: switch to C++17

2022-08-30 Thread Sasha Krassovsky
Hi, What kind of timeline did we decide on? Is this something that can be worked on/merged immediately or should we wait until after 10.0 is out? Sasha Krassovsky > On Aug 29, 2022, at 2:20 AM, Antoine Pitrou wrote: > > > Hello, > > With 5 binding +1 votes, 7 non-binding +1 votes, and no -1

[RESULT][VOTE] C++: switch to C++17

2022-08-29 Thread Antoine Pitrou
Hello, With 5 binding +1 votes, 7 non-binding +1 votes, and no -1 vote, the vote has passed. The next steps will be conceptually as follows: - require C++17 instead of C++11 in the build configuration(s) - remove pre-C++17 compatibility measures in the codebase - start using C++17 idioms and

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Yibo Cai
+1 (binding) On 8/25/22 04:03, Mauricio Vargas Sepúlveda wrote: +1 On 2022-08-24 12:50, Weston Pace wrote: +1 (non-binding) On Wed, Aug 24, 2022 at 9:24 AM Keith Kraus wrote: +1 (non-binding) On Wed, Aug 24, 2022 at 12:12 PM David Li wrote: +1 (binding) On Wed, Aug 24, 2022, at 12:06,

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Niranda Perera
+1 (non-binding) On Wed, Aug 24, 2022 at 5:35 PM Micah Kornfield wrote: > +1, I assume this doesn't impact python wheels. > > On Wed, Aug 24, 2022 at 2:15 PM Sutou Kouhei wrote: > > > +1 > > > > In <7ab9b8ef-d5ca-313f-4b12-79647f32a...@python.org> >

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Micah Kornfield
+1, I assume this doesn't impact python wheels. On Wed, Aug 24, 2022 at 2:15 PM Sutou Kouhei wrote: > +1 > > In <7ab9b8ef-d5ca-313f-4b12-79647f32a...@python.org> > "[VOTE] C++: switch to C++17" on Wed, 24 Aug 2022 17:31:52 +0200, > Antoine Pitrou wro

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Sutou Kouhei
+1 In <7ab9b8ef-d5ca-313f-4b12-79647f32a...@python.org> "[VOTE] C++: switch to C++17" on Wed, 24 Aug 2022 17:31:52 +0200, Antoine Pitrou wrote: > > Hello, > > I would like to propose that the Arrow C++ implementation switch to > C++17 as its baseline sup

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Mauricio Vargas Sepúlveda
+1 On 2022-08-24 12:50, Weston Pace wrote: +1 (non-binding) On Wed, Aug 24, 2022 at 9:24 AM Keith Kraus wrote: +1 (non-binding) On Wed, Aug 24, 2022 at 12:12 PM David Li wrote: +1 (binding) On Wed, Aug 24, 2022, at 12:06, Ivan Ogasawara wrote: +1 (non-binding) On Wed, Aug 24, 2022 at 1

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Weston Pace
+1 (non-binding) On Wed, Aug 24, 2022 at 9:24 AM Keith Kraus wrote: > > +1 (non-binding) > > On Wed, Aug 24, 2022 at 12:12 PM David Li wrote: > > > +1 (binding) > > > > On Wed, Aug 24, 2022, at 12:06, Ivan Ogasawara wrote: > > > +1 (non-binding) > > > > > > On Wed, Aug 24, 2022 at 12:00 PM Sasha

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Keith Kraus
+1 (non-binding) On Wed, Aug 24, 2022 at 12:12 PM David Li wrote: > +1 (binding) > > On Wed, Aug 24, 2022, at 12:06, Ivan Ogasawara wrote: > > +1 (non-binding) > > > > On Wed, Aug 24, 2022 at 12:00 PM Sasha Krassovsky < > krassovskysa...@gmail.com> > > wrote: > > > >> ++1 (non-binding) > >> > >>

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread David Li
+1 (binding) On Wed, Aug 24, 2022, at 12:06, Ivan Ogasawara wrote: > +1 (non-binding) > > On Wed, Aug 24, 2022 at 12:00 PM Sasha Krassovsky > wrote: > >> ++1 (non-binding) >> >> > 24 авг. 2022 г., в 08:53, Jacob Wujciak >> написал(а): >> > + 1 (non-binding) >> > >> > Benjamin Kietzman schrieb

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Ivan Ogasawara
+1 (non-binding) On Wed, Aug 24, 2022 at 12:00 PM Sasha Krassovsky wrote: > ++1 (non-binding) > > > 24 авг. 2022 г., в 08:53, Jacob Wujciak > написал(а): > > + 1 (non-binding) > > > > Benjamin Kietzman schrieb am Mi., 24. Aug. 2022, > > 17:43: > > > >> +1 (binding) > >> > >> On Wed, Aug 24, 2

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Sasha Krassovsky
++1 (non-binding) > 24 авг. 2022 г., в 08:53, Jacob Wujciak > написал(а): > + 1 (non-binding) > > Benjamin Kietzman schrieb am Mi., 24. Aug. 2022, > 17:43: > >> +1 (binding) >> >> On Wed, Aug 24, 2022, 11:32 Antoine Pitrou wrote: >> >>> Hello, >>> I would like to propose that the Arrow C+

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Jacob Wujciak
+ 1 (non-binding) Benjamin Kietzman schrieb am Mi., 24. Aug. 2022, 17:43: > +1 (binding) > > On Wed, Aug 24, 2022, 11:32 Antoine Pitrou wrote: > > > > > Hello, > > > > I would like to propose that the Arrow C++ implementation switch to > > C++17 as its baseline supported version (currently C++1

Re: [VOTE] C++: switch to C++17

2022-08-24 Thread Benjamin Kietzman
+1 (binding) On Wed, Aug 24, 2022, 11:32 Antoine Pitrou wrote: > > Hello, > > I would like to propose that the Arrow C++ implementation switch to > C++17 as its baseline supported version (currently C++11). > > The rationale and subsequent discussion can be read in the archives here: > https://l

[VOTE] C++: switch to C++17

2022-08-24 Thread Antoine Pitrou
Hello, I would like to propose that the Arrow C++ implementation switch to C++17 as its baseline supported version (currently C++11). The rationale and subsequent discussion can be read in the archives here: https://lists.apache.org/thread/9g14n3odhj6kzsgjxr6k6d3q73hg2njr The exact steps an