[jira] [Commented] (ARROW-401) [Java] Floating point vectors should do an approximate comparison in integration tests

2016-12-05 Thread Jacques Nadeau (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723055#comment-15723055 ] Jacques Nadeau commented on ARROW-401: -- good point :D > [Java] Floating point vectors

[jira] [Commented] (ARROW-401) [Java] Floating point vectors should do an approximate comparison in integration tests

2016-12-05 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723050#comment-15723050 ] Julien Le Dem commented on ARROW-401: - this method will return early if f1 is NAN or in

[jira] [Commented] (ARROW-401) [Java] Floating point vectors should do an approximate comparison in integration tests

2016-12-05 Thread Jacques Nadeau (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723000#comment-15723000 ] Jacques Nadeau commented on ARROW-401: -- I wrote it based initially on the code here:

[jira] [Commented] (ARROW-401) [Java] Floating point vectors should do an approximate comparison in integration tests

2016-12-05 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722933#comment-15722933 ] Julien Le Dem commented on ARROW-401: - what is the source for those? Any details on why

[jira] [Commented] (ARROW-401) [Java] Floating point vectors should do an approximate comparison in integration tests

2016-12-02 Thread Jacques Nadeau (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717215#comment-15717215 ] Jacques Nadeau commented on ARROW-401: -- This is what I've used elsewhere before: {code