Jim Apple created ARROW-7395: -------------------------------- Summary: Logical "or" with constants is a Clang warning Key: ARROW-7395 URL: https://issues.apache.org/jira/browse/ARROW-7395 Project: Apache Arrow Issue Type: Bug Components: C++ Affects Versions: 0.15.0 Reporter: Jim Apple Assignee: Jim Apple
With clang version 9.0.1, the C++ debug build fails with: {noformat} In file included from /home/jbapple/code/arrow/cpp/src/arrow/vendored/xxhash/xxhash.h:532: /home/jbapple/code/arrow/cpp/src/arrow/vendored/xxhash/xxhash.c:810:11: error: use of logical '||' with constant operand [-Werror,-Wconstant-logical-operand] if (0 || 0) { ^ ~ /home/jbapple/code/arrow/cpp/src/arrow/vendored/xxhash/xxhash.c:810:11: note: use '|' for a bitwise operation if (0 || 0) { ^~ | {noformat} The simple fix is to add {{-Wno-constant-logical-operand}} to SetupCxxFlags.cmake. -- This message was sent by Atlassian Jira (v8.3.4#803005)