Re: Refactoring the Rust API

On Sun, May 20, 2018 at 2:32 PM, Andy Grove wrote: > Wes, > > Lots of good questions. I'll answer as much as I can but I'm really not > familiar with the C++ implementation and have built the Rust implementation > based on the specs. One of my goals for the IPC and

Re: Refactoring the Rust API

Wes, Lots of good questions. I'll answer as much as I can but I'm really not familiar with the C++ implementation and have built the Rust implementation based on the specs. One of my goals for the IPC and integration testing is to get familiar with the other implementations so that I can make

Re: Refactoring the Rust API

hi Andy, I gave a read through the Rust implementation. I have never programmed in Rust (hope to change that someday!), so some of the programming constructs are lost on me, but I focused on the Arrow columnar questions. My notes / questions follow cheers Wes ## High level comments * Do you

Re: Refactoring the Rust API

Here's my blog post explaining the refactor: https://andygrove.io/2018/05/apache-arrow-traits-generics/ The Reddit thread is going to be here for anyone wanting to see the feedback: https://www.reddit.com/r/rust/comments/8gy45t/refactoring_apache_arrow_to_use_traits_and/ Thanks, Andy. On Wed,

Re: Refactoring the Rust API

There was an interesting blog post posted to Reddit a couple days ago that is very relevant to this refactor. The author is building a dataframe library in Rust and started out with an enum to represent arrays and then moved to using generic traits with the enum.

Re: Refactoring the Rust API

So it turns out this refactor isn't as disruptive as I thought and I mostly have it working already. The buffer/builder/list types barely change at all other than the fact that we no longer need all those macros after moving to generics. It really is only array.rs that is pretty much a rewrite.

Refactoring the Rust API

I filed a PR to track this (https://issues.apache.org/jira/browse/ARROW-2521) but thought it was worth raising on the mailing list too. I am running into limitations now of the way that Array is represented as an enum and I am unable to implement List with the current design. When