Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-30 Thread Sutou Kouhei
If we don't care the rustfmt check for release, how about removing the check from dev/release/verify-release-candidate.sh? In "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Sun, 29 Sep 2019 17:40:20 -0700, Andy Grove wrote: > Actually, I think the RC was cut just

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-30 Thread Krisztián Szűcs
; > > > > >> > > Ok(()) > > >> > > } > > >> > > - > > >> > > } > > >> > > > > >> > > Diff in > > >> > > > > >> > > > >> > /tmp/a

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-30 Thread Krisztián Szűcs
- >>> > > } >>> > > >>> > > Diff in >>> > > >>> > >>> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >>> > > merge.rs at line 134: >>> > > >>

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-29 Thread Andy Grove
dev/release/verify-release-candidate.sh. It install > Rust automatically. > Should we update > > https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L452 > ? > > In > "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Sun, 2

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-29 Thread Sutou Kouhei
I used dev/release/verify-release-candidate.sh. It install Rust automatically. Should we update https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L452 ? In "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Sun, 29 Sep 2019 07:21:27 -06

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-29 Thread Micah Kornfield
> > > } >> > > >> > > Diff in >> > > >> > >> /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/physical_plan/ >> > > projection.rs at line 171: >> > > >> > > Ok(()) >> > > } >> > >

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-29 Thread Andy Grove
t; selection.rs at line 180: > > > > Ok(()) > > } > > - > > } > > > > Diff in > > > /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ > > projection.rs at line 141: > > > > assert_

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-29 Thread Wes McKinney
t; > assert_eq!("c1", batch.schema().field(0).name()); > } > - > } > > Diff in > /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/execution/ > table_impl.rs at line 315: > true, > ); > } > - > } > > Dif

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Sutou Kouhei
/apache-arrow-0.15.0/rust/datafusion/src/logicalplan.rs at line 641: println!("plan: {:?}", plan1); }); } - } Diff in /tmp/arrow-0.15.0.tGMnP/apache-arrow-0.15.0/rust/datafusion/src/sql/planner.rs at line 569: } } } - } Thanks, -

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Sutou Kouhei
Thanks. We can ignore the warning. If your key is signed by another trusted key, the warning will be suppressed. (You can trust your key ultimately by "gpg --edit-key E47C810A90FE21FF448DA938755E743692EA1D85 trust".) In "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1&

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Sutou Kouhei
splayed about my identity. Could you show the real warning message as-is? Thanks, -- kou In "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Sat, 28 Sep 2019 17:05:01 -0700, Micah Kornfield wrote: > Yes I re-ran the command. The re-upload fixed issues I had

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Micah Kornfield
; UPLOAD_UBUNTU_APT=1 \ > UPLOAD_CENTOS_YUM=1 \ > dev/release/03-binary.sh 0.15.0 1 ... > > > Thanks, > -- > kou > > In > "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Fri, 27 Sep > 2019 18:45:47 -0600, > Micah Kornfield

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Sutou Kouhei
/release/03-binary.sh 0.15.0 1 ... Thanks, -- kou In "Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1" on Fri, 27 Sep 2019 18:45:47 -0600, Micah Kornfield wrote: > I'm seeing issues with a bad signature on Centos binaries (I had to > regenerate some files here beca

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-28 Thread Wes McKinney
It definitely isn't ideal. It might be more expedient for Krisztián to cut an RC2 and sort out the GPG issue for you for next time. If we go that route are there any additional patches we want to include in a new RC? On Fri, Sep 27, 2019, 8:46 PM Micah Kornfield wrote: > I'm seeing issues with

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-27 Thread Micah Kornfield
I'm seeing issues with a bad signature on Centos binaries (I had to regenerate some files here because my signature was initially missing from the dev KEYS file). Can anyone else confirm? Also, for Debian and Ubuntu I'm seeing warnings about not being able to verify the identify of my signature

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-27 Thread Wes McKinney
@David -- the macOS conda-based build is a bit finicky due to the SDK-related issues. In any case since we can successfully produce macOS binaries for Homebrew and wheel/conda, that's the most important thing, though we should aim for a more refined out-of-the-box development experience Not sure

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-27 Thread Micah Kornfield
> > I checked in the key to https://dist.apache.org/repos/dist/release/arrow/. > Is there something else I need to do to make it available for verification? To answer my own question I think I missed adding them to the the dev branch (I just did this so hopefully they will propagate soon). On

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-27 Thread Andy Grove
+1 for Rust implementation. Tests run fine out the box. Version numbers are correct. On Fri, Sep 27, 2019 at 7:26 AM David Li wrote: > I ran the source verification script on MacOS 10.12 (Sierra). > > I found that Micah's GPG key did not seem to be in KEYS and had to > import it manually. > >

Re: Subject: [VOTE] Release Apache Arrow 0.15.0 - RC1

2019-09-27 Thread David Li
I ran the source verification script on MacOS 10.12 (Sierra). I found that Micah's GPG key did not seem to be in KEYS and had to import it manually. Python failed in pyarrow/tests/test_cython.py::test_cython_api when invoking gcc. Is this the MacOS conda toolchain issue? It works if I add