Re: unclear compilation errors with util::optional

2022-09-22 Thread Yaron Gvili
Updating with master fixed it, thanks. Yaron. From: Antoine Pitrou Sent: Thursday, September 22, 2022 4:28 AM To: dev@arrow.apache.org Subject: Re: unclear compilation errors with util::optional Hi Yaron, On git master we recently moved to C++17 and

Re: unclear compilation errors with util::optional

2022-09-22 Thread Antoine Pitrou
Hi Yaron, On git master we recently moved to C++17 and therefore removed compatibility backports such as arrow::util::optional. Now you should just use std::optional. So be sure to rebase your work on master and fix any reference to those compatibility backports in your code. Regards A

unclear compilation errors with util::optional

2022-09-22 Thread Yaron Gvili
Hi, In a PR I'm working on [1], I get compilation errors in CI jobs that I don't see the reason for. I'd appreciate help with this. For example, one job's [2] compilation complains about the util::optional symbol not being declared (this happens in other jobs too). This is unclear for a couple