Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/ --- (Updated Oct. 4, 2019, 8:21 p.m.) Review request for atlas, Austin Nobis, Ashut

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 35 (patched) > > > > > > How do we know the class na

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > pom.xml > > Lines 766 (patched) > > > > > > I would avoid using lombok if it is not already present in the project. > > Na Li wrote: > I am checking with At

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> On Oct. 3, 2019, 4:55 a.m., radford nguyen wrote: > > addons/ml-bridge/src/main/java/org/apache/atlas/ml/governance/MlGovernanceHookTool.java > > Lines 228 (patched) > > > > > > Apache commons has a built-in helper

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 28 (patched) > > > > > > This comment is confus

[jira] [Created] (ATLAS-3440) Get ML metadata from ML service using HTTP client

2019-10-04 Thread Na Li (Jira)
Na Li created ATLAS-3440: Summary: Get ML metadata from ML service using HTTP client Key: ATLAS-3440 URL: https://issues.apache.org/jira/browse/ATLAS-3440 Project: Atlas Issue Type: Task

[jira] [Updated] (ATLAS-3432) Add Machine Learning Governance integration

2019-10-04 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3432: - Description: Managing machine learning models and its deployments are getting more important over time. Adding t

[jira] [Commented] (ATLAS-3437) UI: Allows users to perform wildcard searches on classification

2019-10-04 Thread Sameer Shaikh (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944483#comment-16944483 ] Sameer Shaikh commented on ATLAS-3437: -- Note: only * support at server end.  > UI:

[jira] [Updated] (ATLAS-3437) UI: Allows users to perform wildcard searches on classification

2019-10-04 Thread Sameer Shaikh (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer Shaikh updated ATLAS-3437: - Description: UI for entity search supporting wildcard for classification filter. > UI: Allows us

[jira] [Assigned] (ATLAS-3437) UI: Allows users to perform wildcard searches on classification

2019-10-04 Thread Sameer Shaikh (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer Shaikh reassigned ATLAS-3437: Assignee: Sameer Shaikh (was: Keval Bhatt) > UI: Allows users to perform wildcard searche

[jira] [Updated] (ATLAS-3437) UI: Allows users to perform wildcard searches on classification

2019-10-04 Thread Sameer Shaikh (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sameer Shaikh updated ATLAS-3437: - Attachment: ATLAS-3437.patch > UI: Allows users to perform wildcard searches on classification >