Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-10-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186808 --- Ship it! - Abhay Kulkarni On Sept. 30, 2017, 9:58 p.m., Madha

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 30, 2017, 9:58 p.m.) Review request for atlas, Apoorv Naik, Ashu

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-30 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186787 --- Fix it, then Ship it! notification/src/main/java/org/apache/at

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 30, 2017, 11:51 a.m.) Review request for atlas, Apoorv Naik, Ash

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186757 --- notification/src/main/java/org/apache/atlas/notification/Abstract

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186755 --- Fix it, then Ship it! Ship It! notification/src/main/java/org

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 29, 2017, 10:32 p.m.) Review request for atlas, Apoorv Naik, Ash

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186683 --- common/src/main/java/org/apache/atlas/AtlasConfiguration.java Lin

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Abhay Kulkarni
> On Sept. 29, 2017, 3:15 a.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > > Lines 163 (patched) > > > > > > This call is already used in Atlas (a

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 29, 2017, 6:30 a.m.) Review request for atlas, Apoorv Naik, Ashu

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186641 --- notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTe

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186630 --- notification/src/main/java/org/apache/atlas/notification/Abstract

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186624 --- notification/src/main/java/org/apache/atlas/notification/Abstract

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 29, 2017, 12:26 a.m.) Review request for atlas, Apoorv Naik, Ash

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/#review186617 --- I would have liked more unit tests, since this is core functionali

Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- Review request for atlas, Apoorv Naik, Ashutosh Mestry, Abhay Kulkarni, Sarath S

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62681/ --- (Updated Sept. 28, 2017, 11:08 p.m.) Review request for atlas, Apoorv Naik, Ash