Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68287/ --- Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Ni

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68287/#review207060 --- Fix it, then Ship it! intg/src/main/java/org/apache/atlas/Atla

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68287/#review207065 --- Please look at the question I posted to the JIRA - I am not sure t

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68287/#review207066 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Sarath Subramanian
> On Aug. 10, 2018, 3:37 a.m., Graham Wallis wrote: > > Please look at the question I posted to the JIRA - I am not sure that you > > always want the specified behaviour. The behavior doesn't depend on the nature of the relationship, although the example showcases retaining propagated tags for

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Sarath Subramanian
> On Aug. 10, 2018, 4:01 a.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java > > Line 56 (original) > > > > > > I assume this is implementing the