Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/#review215475 --- Ship it! Ship It! - Sridhar K On May 22, 2019, 5:36 p.m.,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/#review215472 --- Ship it! Ship It! - Sarath Subramanian On May 22, 2019,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 5:36 p.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/#review215450 --- Fix it, then Ship it! addons/impala-bridge/pom.xml Line 184

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 2:35 a.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/#review215432 ---

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 7:09 p.m., Sridhar K wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaHook.java > > Lines 19 (patched) > > > > > > Please package name w.r.t. directories. There are

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 2:15 a.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 7:27 p.m., Sridhar K wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/BaseImpalaEvent.java > > Lines 107 (patched) > > > > > > getTableNameFromColumn ==>

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 6:18 p.m., Sridhar K wrote: > > addons/impala-bridge/pom.xml > > Lines 59 (patched) > > > > > > Can we remove the project version hereand define dependency version > > in root pom.xml file's

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 6:18 p.m., Sridhar K wrote: > > addons/impala-bridge-shim/pom.xml > > Lines 41 (patched) > > > > > > Can we remove the project version hereand define dependency version > > in root pom.xml

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 21, 2019, 10:10 p.m.) Review request for atlas, Fredy Wijaya,