Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
> On Nov. 13, 2019, 8:37 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > > Lines 484 (patched) > > > > > > should this be AtlasPrivile

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218637 --- Ship it! Ship It! - Sarath Subramanian On Nov. 14, 2019, 11:

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- (Updated Nov. 14, 2019, 7:10 p.m.) Review request for atlas, Ashutosh Mestry, M

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
> On Nov. 14, 2019, 12:02 a.m., Ashutosh Mestry wrote: > > My thinking is that there should be a bulk API that should take JSON > > payload of entities to be purged. Generally, there are large number of > > deleted entities. There should be a convinent way to purge them. Right now > > the quer

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
> On Nov. 14, 2019, midnight, Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > > Lines 159 (patched) > > > > > > Does this mean that if purge is re

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218627 --- My thinking is that there should be a bulk API that should take JS

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218626 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Sidharth Mishra
> On Nov. 13, 2019, 8:37 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > > Lines 484 (patched) > > > > > > should this be AtlasPrivile

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- (Updated Nov. 13, 2019, 9:04 p.m.) Review request for atlas, Ashutosh Mestry, M

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218622 --- Fix it, then Ship it! repository/src/main/java/org/apache/atla

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218615 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 13, 2019, 6:04

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- (Updated Nov. 13, 2019, 6:04 a.m.) Review request for atlas, Ashutosh Mestry, M

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218614 --- authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivi

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- (Updated Nov. 13, 2019, 12:30 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- (Updated Nov. 12, 2019, 11:54 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
> On Nov. 9, 2019, 7:03 a.m., Madhan Neethiraj wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > > Lines 442 (patched) > > > > > > Consider adding another method in a subsequent patc

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-08 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218585 --- intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV

Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-07 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subraman