Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/#review220920 --- Ship it! Ship It! - Madhan Neethiraj On May 30, 2020, 2:24 a

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-29 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/ --- (Updated May 30, 2020, 2:24 a.m.) Review request for atlas, Ashutosh Mestry, Ma

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/#review220909 --- Ship it! Ship It! - Madhan Neethiraj On May 28, 2020, 11:01

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/#review220908 --- Ship it! Ship It! - Sarath Subramanian On May 28, 2020, 4:01

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/ --- (Updated May 28, 2020, 11:01 p.m.) Review request for atlas, Ashutosh Mestry, M

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/ --- (Updated May 28, 2020, 10:58 p.m.) Review request for atlas, Ashutosh Mestry, M

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
> On May 26, 2020, 10:45 p.m., Madhan Neethiraj wrote: > > Sid - I suggest to consider the following alternate approach to address > > this issue: > > > > public class EntityGraphMapper{ > > private AtlasEntityHeader constructHeader(AtlasEntity entity, final > > AtlasEntityType type, Atl

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/#review220873 --- Sid - I suggest to consider the following alternate approach to ad

Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-22 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subraman