Re: Review Request 72932: ATLAS-3964: Fix for regression caused by earlier patch

2020-10-06 Thread keval bhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72932/#review221997 --- Ship it! Ship It! - keval bhatt On Oct. 6, 2020, 2:05 a.m.,

Re: Review Request 72932: ATLAS-3964: Fix for regression caused by earlier patch

2020-10-05 Thread Deep Singh
> On Oct. 6, 2020, 2:13 a.m., Ashutosh Mestry wrote: > > LGTM. I will let Keval review it. Perhaps there is some JS where all these > > re-usable methods are kept. Right now there is duplication of code. Its not duplication of code. There are two codebases for UI. DashboardV2 and DashboardV3.

Re: Review Request 72932: ATLAS-3964: Fix for regression caused by earlier patch

2020-10-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72932/#review221994 --- LGTM. I will let Keval review it. Perhaps there is some JS where

Review Request 72932: ATLAS-3964: Fix for regression caused by earlier patch

2020-10-05 Thread Deep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72932/ --- Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.