Re: Review Request 73076: Deferred Actions Implementation

2021-04-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated April 13, 2021, 4:28 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-04-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated April 8, 2021, 11:26 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-03-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 13, 2021, 1 a.m.) Review request for atlas, Jayendra Parab, Madh

Re: Review Request 73076: Deferred Actions Implementation

2021-03-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 12, 2021, 8:29 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 12, 2021, 6:41 a.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Ashutosh Mestry via Review Board
> On March 11, 2021, 8:52 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2817 (patched) > > > > > > this will end up re-addi

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222669 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222668 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2021-03-10 Thread Ashutosh Mestry via Review Board
> On March 9, 2021, 6:27 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/tasks/AtlasTask.java > > Lines 184 (patched) > > > > > > - getTaskVertex() => getAdditionalInfo()? > > - @Json

Re: Review Request 73076: Deferred Actions Implementation

2021-03-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 11, 2021, 6:49 a.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-03-08 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222660 --- intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.ja

Re: Review Request 73076: Deferred Actions Implementation

2021-03-08 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222659 --- Ship it! Ship It! - Sarath Subramanian On March 8, 2021, 10:

Re: Review Request 73076: Deferred Actions Implementation

2021-03-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 8, 2021, 6:19 p.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-03-03 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222654 --- Fix it, then Ship it! intg/src/main/java/org/apache/atlas/type

Re: Review Request 73076: Deferred Actions Implementation

2021-02-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 26, 2021, 6:08 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-24 Thread Ashutosh Mestry via Review Board
> On Feb. 19, 2021, 8:58 p.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/repository/Constants.java > > Lines 212 (patched) > > > > > > - TASK_TYPE_PROPERTY_KEY and TASK_TYPE are duplicates >

Re: Review Request 73076: Deferred Actions Implementation

2021-02-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 25, 2021, 5:27 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222619 --- common/src/main/java/org/apache/atlas/repository/Constants.java L

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
> On Feb. 18, 2021, 7:14 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2780 (patched) > > > > > > the taskDef guid should b

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
> On Feb. 18, 2021, 7:52 a.m., Sarath Subramanian wrote: > > one improvement to add (can be taken up in a follow-up patch) - add the > > task id to the entity vertex as well, so from entity details page we will > > know how many pending tasks are in process. I will address this in this patch.

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 19, 2021, 3:49 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222608 --- Here are comments for partial review; will complete the review in

Re: Review Request 73076: Deferred Actions Implementation

2021-02-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222610 --- Fix it, then Ship it! one improvement to add (can be taken up i

Re: Review Request 73076: Deferred Actions Implementation

2021-02-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222609 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2021-02-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 17, 2021, 5:55 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222588 --- common/src/main/java/org/apache/atlas/repository/Constants.java L

Re: Review Request 73076: Deferred Actions Implementation

2021-02-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 11, 2021, 7:12 p.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 11, 2021, 6:37 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-10 Thread Ashutosh Mestry via Review Board
> On Feb. 5, 2021, 7:16 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/tasks/TaskDef.java > > Lines 65 (patched) > > > > > > Since TaskDef will be serialized/deserialized, consider using

Re: Review Request 73076: Deferred Actions Implementation

2021-02-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:40 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:25 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-02-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222569 --- intg/src/main/java/org/apache/atlas/model/tasks/TaskDef.java Line

Re: Review Request 73076: Deferred Actions Implementation

2021-02-05 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222552 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2021-02-04 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222558 --- intg/src/main/java/org/apache/atlas/AtlasConfiguration.java Lines

Re: Review Request 73076: Deferred Actions Implementation

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 25, 2021, 11:08 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-01-21 Thread Jayendra Parab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222507 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2021-01-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 20, 2021, 11:14 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation

2021-01-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 19, 2021, 6:31 p.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-01-19 Thread Ashutosh Mestry via Review Board
> On Jan. 10, 2021, 9:43 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2037 (patched) > > > > > > consider adding tags to im

Re: Review Request 73076: Deferred Actions Implementation

2021-01-12 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222458 --- repository/src/test/java/org/apache/atlas/repository/tagpropagati

Re: Review Request 73076: Deferred Actions Implementation

2021-01-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 12, 2021, 6:34 a.m.) Review request for atlas, Jayendra Parab, Ma

Re: Review Request 73076: Deferred Actions Implementation

2021-01-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/#review222428 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

Re: Review Request 73076: Deferred Actions Implementation

2020-12-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Dec. 16, 2020, 11:42 p.m.) Review request for atlas, Jayendra Parab, M

Re: Review Request 73076: Deferred Actions Implementation: Work In Progress

2020-12-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Dec. 16, 2020, 5:18 a.m.) Review request for atlas, Jayendra Parab, Ma