Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-13 Thread Nikhil Bonte
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222808 ---

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 12, 2021, 4:31 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-12 Thread Ashutosh Mestry via Review Board
> On April 12, 2021, 1:43 p.m., Nikhil Bonte wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java > > Lines 246 (patched) > > > > > > remove extra blank line Done.

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-12 Thread Nikhil Bonte
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222803 --- Ship it!

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222801 --- Ship it! Ship It! - Sarath Subramanian On April 9, 2021,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 11:41 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
> On April 9, 2021, 10:18 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java > > Lines 40 (patched) > > > > > > consider moving line 35 here,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222797 --- Fix it, then Ship it!

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 9:14 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 5:04 a.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-08 Thread Ashutosh Mestry via Review Board
> On April 8, 2021, 11:26 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java > > Line 49 (original), 50 (patched) > > > > > > can we call

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-08 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222790 ---

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 2, 2021, 4:18 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated March 25, 2021, midnight) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-24 Thread Ashutosh Mestry via Review Board
> On March 22, 2021, 6:08 p.m., Madhan Neethiraj wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java > > Line 173 (original), 175 (patched) > > > > > > if hive_process and

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-22 Thread Sarath Subramanian
> On March 22, 2021, 11:08 a.m., Madhan Neethiraj wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > > Line 185 (original), 191 (patched) > > > > > > It might be simpler to skip

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222727 ---

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated March 22, 2021, 5:23 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/#review222721 ---

Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- Review request for atlas, Madhan Neethiraj and Sarath Subramanian. Bugs: