Shwetha G S created ATLAS-964: --------------------------------- Summary: Cleanup NOTICE and LICENSE Key: ATLAS-964 URL: https://issues.apache.org/jira/browse/ATLAS-964 Project: Atlas Issue Type: Bug Reporter: Shwetha G S Assignee: Shwetha G S Priority: Blocker Fix For: 0.7-incubating
{noformat} Hi, We have removed the glyphicons fonts, updated the license and notice to match the source contents. Will you be able to do a quick check to see if we are missing anything here: https://github.com/apache/incubator-atlas/tree/0.7-incubating? License looks good to me only two very minor things I can see you / may not want to change: - No need for the quotes around MIT license or the like. I've seen this done elsewhere but can't think of a reason for doing so. Rabbit ears / scare quotes [1] can imply that it's actually not the correct license or that it's a MIT like license. - Why not legally required I include the a pointer to the public domain text. Notice is a bit odd, why have the section "Titan also includes software from other open source projects including..."? Are these things bundled or just dependancies? If they are just dependancies there is no need to mention then in NOTICE, move them to a DEPENDENCIES files if you think it is useful information to tell the user of the software. (Feel free to post this to the list for discussion if you want) Thanks, Justin 1. https://en.wikipedia.org/wiki/Scare_quotes {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)