Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-22 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99954 --- Ship it! Ship It! - Suma Shivaprasad On Sept. 22, 2015, 9:09 a.m

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-22 Thread Shwetha GS
> On Sept. 21, 2015, 3:36 p.m., Suma Shivaprasad wrote: > > docs/src/site/twiki/TypeSystem.twiki, line 8 > > > > > > pls add docs for modelling unique entities by qualifiedName I have added in EntitiesResource API. Cu

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-22 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 22, 2015, 9:09 a.m.) Review request for atlas. Changes ---

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-22 Thread Shwetha GS
> On Sept. 21, 2015, 3:22 p.m., Suma Shivaprasad wrote: > > typesystem/src/main/java/org/apache/atlas/ApplicationProperties.java, line > > 32 > > > > > > have we moved this from client to ypesystem? yes > On Sept.

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-21 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99752 --- typesystem/src/main/java/org/apache/atlas/ApplicationProperties.jav

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-21 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99753 --- docs/src/site/twiki/TypeSystem.twiki (line 8)

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-21 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99747 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphBac

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-21 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 21, 2015, 8:13 a.m.) Review request for atlas. Changes ---

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Shwetha GS
> On Sept. 18, 2015, 7:04 a.m., Suma Shivaprasad wrote: > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java, > > line 139 > > > > > > should we throw and exceptiopn instead? some configs li

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 18, 2015, 11:14 a.m.) Review request for atlas. Changes --

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99522 --- notification/src/main/java/org/apache/atlas/kafka/KafkaNotification

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Shwetha GS
> On Sept. 18, 2015, 6:24 a.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 110 > > > > > > we should make rge readTimeout configurable and also add connectTimeout read t

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99499 --- notification/src/main/java/org/apache/atlas/kafka/KafkaNotification

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99498 --- distro/src/conf/application.properties (line 52)

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99487 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHoo

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/#review99486 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveM

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-18 Thread Shwetha GS
> On Sept. 18, 2015, 5:29 a.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java, > > line 296 > > > > > > is sdQualifiedName supposed to be same as

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-15 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 15, 2015, 6:33 a.m.) Review request for atlas. Bugs: ATLAS-58

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-15 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 15, 2015, 6:50 a.m.) Review request for atlas. Changes ---

Re: Review Request 38393: ATLAS-58 Make hive hook reliable

2015-09-15 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38393/ --- (Updated Sept. 15, 2015, 6:56 a.m.) Review request for atlas. Bugs: ATLAS-58