Re: Review Request 36611: ATLAS-74 Create notification framework

2015-07-21 Thread Shwetha GS
On July 20, 2015, 11:16 p.m., Seetharam Venkatesh wrote: notification/src/main/java/org/apache/atlas/notification/NotificationModule.java, line 26 https://reviews.apache.org/r/36611/diff/1/?file=1016160#file1016160line26 Is there a way to externalize this? How do folks say wrap

Re: Review Request 36611: ATLAS-74 Create notification framework

2015-07-21 Thread Shwetha GS
On July 20, 2015, 11:16 p.m., Seetharam Venkatesh wrote: client/src/main/java/org/apache/atlas/PropertiesUtil.java, line 42 https://reviews.apache.org/r/36611/diff/1/?file=1016152#file1016152line42 Merge may have conflicts, no? Isnt this dangerous? Why cant we treat this separate

Re: Review Request 36611: ATLAS-74 Create notification framework

2015-07-20 Thread Seetharam Venkatesh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36611/#review92333 --- client/src/main/java/org/apache/atlas/PropertiesUtil.java (line