Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-28 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 28, 2016, 8:55 p.m.) Review request for atlas and Suma

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-28 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review130975 --- Ship it! Ship It! - Suma Shivaprasad On April 23, 2016,

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-23 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 23, 2016, 12:53 p.m.) Review request for atlas and Suma

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-22 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review130247 --- docs/src/site/twiki/Search.twiki (line 31)

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-20 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129773 --- docs/src/site/twiki/Search.twiki (line 29)

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-20 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129769 --- docs/src/site/twiki/Search.twiki (line 90)

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-20 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 20, 2016, 1:46 p.m.) Review request for atlas, David Kantor and

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-20 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 20, 2016, 1:01 p.m.) Review request for atlas, David Kantor and

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129670 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129669 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Suma Shivaprasad
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333 > > > > > > pls add to documentaion in search.twiki > > Neeru Gupta wrote: >

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Neeru Gupta
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333 > > > > > > pls add to documentaion in search.twiki Which wiki page is that?

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 19, 2016, 6:14 p.m.) Review request for atlas, David Kantor and

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-19 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 19, 2016, 5:46 p.m.) Review request for atlas, David Kantor and

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-15 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129154 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-15 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129153 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-15 Thread Suma Shivaprasad
> On April 15, 2016, 4:45 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 336 > > > > > > Can you pls follow sql syntax for [asc, desc] - similiar to > >

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-15 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129150 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-15 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/#review129145 ---

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-14 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 14, 2016, 2:11 p.m.) Review request for atlas, David Kantor and

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-14 Thread Jeff Hagelberg
> On April 7, 2016, 7:55 p.m., Jeff Hagelberg wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala, > > line 99 > > > > > > I would suggest adding an intermediate variable here for the

Re: Review Request 45499: ATLAS-436, ATLAS-435 order by and limit clause for DSL queries

2016-04-13 Thread Neeru Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45499/ --- (Updated April 14, 2016, 2:15 a.m.) Review request for atlas, David Kantor and