Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-06 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/#review131998 --- Ship it! Ship It! - Hemanth Yamijala On May 6, 2016, 7:12 a.

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-06 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/ --- (Updated May 6, 2016, 7:12 a.m.) Review request for atlas. Bugs: ATLAS-585

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-05 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/#review131990 --- Fix it, then Ship it! Mostly fine - very minor nits to take car

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-05 Thread Hemanth Yamijala
> On May 4, 2016, 7:34 a.m., Hemanth Yamijala wrote: > > client/src/main/java/org/apache/atlas/AtlasClient.java, line 130 > > > > > > Can we retain the javadocs? There are still some deleted ones. This method, for e

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-05 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/ --- (Updated May 5, 2016, 10:32 a.m.) Review request for atlas. Changes ---

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-05 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/ --- (Updated May 5, 2016, 9:07 a.m.) Review request for atlas. Changes --- A

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-05 Thread Shwetha GS
> On May 4, 2016, 7:34 a.m., Hemanth Yamijala wrote: > > client/src/main/java/org/apache/atlas/AtlasAdminClient.java, line 63 > > > > > > Not related to this patch, but since we are touching it, should we just > > ge

Re: Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-05-04 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/#review131623 --- client/src/main/java/org/apache/atlas/AtlasAdminClient.java (line

Review Request 46650: ATLAS-585 NotificationHookConsumer creates new AtlasClient for every message

2016-04-25 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/ --- Review request for atlas. Bugs: ATLAS-585 https://issues.apache.org/jira/br