Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

> On May 12, 2016, 10:45 a.m., Shwetha GS wrote: > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java, > > line 239 > > > > > > Move this logice of if auto commit disabled, call commi

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/ --- (Updated May 12, 2016, 12:59 p.m.) Review request for atlas, Shwetha GS and Tom

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/#review132870 --- Fix it, then Ship it! Minor comment webapp/src/main/java/org/

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

> On May 11, 2016, 12:32 p.m., Shwetha GS wrote: > > notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java, line > > 40 > > > > > > rename to lastSeenOffset? Done. On May 11, 2016, 12:32 p.m., Heman

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

> On May 11, 2016, 1:06 p.m., Tom Beerbower wrote: > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java, > > lines 63-67 > > > > > > Just for organization, could this be moved under

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/ --- (Updated May 12, 2016, 7:47 a.m.) Review request for atlas, Shwetha GS and Tom

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/#review132649 --- Fix it, then Ship it! Looks good. A couple of minor questions.

Re: Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/#review132630 --- notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.j

Review Request 47181: ATLAS-629: Kafka messages in ATLAS_HOOK might be lost in HA mode at the instant of failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47181/ --- Review request for atlas, Shwetha GS and Tom Beerbower. Bugs: ATLAS-629 htt