Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, > > line 37 > > > > > > If I understood this correctly, the basepipe for the Greml

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, > > line 116 > > > > > > Both these TODOs are kind of important, and we need t

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133702 --- Ship it! My comments which we agreed to address in this patch a

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/ --- (Updated May 17, 2016, 10:41 p.m.) Review request for atlas and Hemanth Yamijal

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, > > line 37 > > > > > > If I understood this correctly, the basepipe for the Greml

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:41 a.m., Hemanth Yamijala wrote: > > > > John Speidel wrote: > ok, I will use the other constructor along with calling of the necessary > setters. > But to be honest, why this constructor should be marked this way makes > absolutely no sense to me. I agree and we

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 7:50 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, > > line 37 > > > > > > When would the UI flows use this service as opposed to the ori

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java, > > line 80 > > > > > > Would it help to update m_qualifiedToCleanMap with the resu

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:42 p.m., Madhan Neethiraj wrote: > > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java, > > line 38 > > > > > > This comment is present in DefaultDateFormatter() as well. C

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 8:04 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java, > > line 116 > > > > > > Both these TODOs are kind of important, and we need t

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:40 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java, line > > 57 > > > > > > This would be a problem if multiple threads are trying to defin

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:59 a.m., Hemanth Yamijala wrote: > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java, > > line 37 > > > > > > If I understood this correctly, the basepipe for the Greml

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 7:50 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, > > line 37 > > > > > > When would the UI flows use this service as opposed to the ori

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java, > > line 35 > > > > > > Trying to access these resources with master is giving me this

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote: > > > > John Speidel wrote: > Yes, I was originally using this but no longer need to access this method. > I will revert to private. oops, this comment was for the first issue regarding the scope of GraphHelper.findVertex() > On M

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133355 --- John - here are my review comments so far. I will complete rest of

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 2:27 p.m., Hemanth Yamijala wrote: > > Good catch Hemanth. This property is supposed to default to 'true' but at some point during cleanup/refactoring I broke this and didn't catch it because all of my functional tests set this value and there is no unit test for this. I wil

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:41 a.m., Hemanth Yamijala wrote: > > ok, I will use the other constructor along with calling of the necessary setters. But to be honest, why this constructor should be marked this way makes absolutely no sense to me. - John -

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 6:31 a.m., Hemanth Yamijala wrote: > > "id" is the "clean" form for the underlying "__guid" property. The mapping between clean and fully qualified property names is handled by the PropertyMapper implementation. The user only deals with the clean name which is then translat

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 5:17 a.m., Hemanth Yamijala wrote: > > ok - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133325 ---

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 4:53 a.m., Hemanth Yamijala wrote: > > Actually this change shouldn't have been included in the patch. It was from an old local commit to fix the error message. I will revert back to the old msg. - John --- This is an

Re: Review Request 47382: ATLAS-491 : Business Catalog API

> On May 16, 2016, 4:09 a.m., Hemanth Yamijala wrote: > > Yes, I was originally using this but no longer need to access this method. I will revert to private. - John --- This is an automatically generated e-mail. To reply, visit: https:

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133357 --- catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceP

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review19 --- catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceP

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review17 --- webapp/src/main/java/org/apache/atlas/web/resources/EntityService

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review12 --- catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQ

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review11 --- catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review10 --- catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvid

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133328 --- catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133325 --- webapp/src/main/java/org/apache/atlas/web/resources/EntityService

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133323 --- typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedS

Re: Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/#review133322 --- repository/src/main/java/org/apache/atlas/repository/graph/GraphH

Review Request 47382: ATLAS-491 : Business Catalog API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47382/ --- Review request for atlas and Hemanth Yamijala. Bugs: ATLAS-491 https://issu