Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review135160 --- Ship it! Ship It! - Suma Shivaprasad On May 26, 2016, 6:04

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, > > line 345 > > > > > > its better to load the newTable from metastore here

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/ --- (Updated May 26, 2016, 6:04 p.m.) Review request for atlas and Shwetha GS.

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

> On May 26, 2016, 3:25 a.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, > > line 345 > > > > > > its better to load the newTable from metastore here

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134911 ---

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

> On May 24, 2016, 7:18 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java, > > line 745 > > > > > > can you pls add a test with column position changed as

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134618 --- Ship it! Ship It! - Suma Shivaprasad On May 23, 2016, 6:52

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134617 ---

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134616 ---

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/ --- (Updated May 23, 2016, 6:52 a.m.) Review request for atlas and Shwetha GS.

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

> On May 20, 2016, 4:08 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, > > line 312 > > > > > > pls change var name from nameChanged to nameNotModified.

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/ --- (Updated May 20, 2016, 5:50 p.m.) Review request for atlas and Shwetha GS.

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134157 ---

Re: Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/#review134143 ---

Review Request 47638: ATLAS-752 Column rename in Hive should retain traits/tags associated with it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47638/ --- Review request for atlas. Bugs: ATLAS-752